From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92946C7EE2A for ; Fri, 12 May 2023 09:36:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240276AbjELJgz (ORCPT ); Fri, 12 May 2023 05:36:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229670AbjELJgw (ORCPT ); Fri, 12 May 2023 05:36:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64C0B5FCD; Fri, 12 May 2023 02:36:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EEA3864F4E; Fri, 12 May 2023 09:36:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49013C433EF; Fri, 12 May 2023 09:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683884210; bh=sFzboBVIPgpCAMpaLOZuuYbAaS8obMt0kAlpbkh4Lus=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HUoacoqO9ZEu6OVD9XqX296JFFGvcazTM0Qygj9vWVTL9FaBMQyw+mA3/u9inJ68K LUNfF8oWxpnEg796GF1QXupnsiEEShj1dZWnC1N+VFJ8kEtpx5U2t4mQYDm4QGPSVO VcV231jBkWVigcVZP/Y8yHaBpn8Y6/bkPBQ5vN6IISK5v2kIVyZ5rvtAGgfT4jgWux 4Jz/OR5Tnc1ss3hD5d0CuV4dP1wPwkulzN6l3UCS4A/2DxhLqmytlY23Lb746pkgFQ kHkcKH3zTY4RaCgz79U23o0gS1K+WivTaHbP7ixDnGFzS/v5pdB/97GFKVO8vFQEso 7hYohFzG67iVg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pxPDB-00039Y-Ad; Fri, 12 May 2023 11:37:18 +0200 Date: Fri, 12 May 2023 11:37:17 +0200 From: Johan Hovold To: Bjorn Andersson Cc: Vinod Koul , Kishon Vijay Abraham I , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , Bryan O'Donoghue , Abel Vesa , Steev Klimaszewski , Johan Hovold Subject: Re: [PATCH v2 6/8] phy: qcom-qmp-combo: Introduce drm_bridge Message-ID: References: <20230510031930.1996020-1-quic_bjorande@quicinc.com> <20230510031930.1996020-7-quic_bjorande@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230510031930.1996020-7-quic_bjorande@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 09, 2023 at 08:19:28PM -0700, Bjorn Andersson wrote: > The QMP combo PHY sits in an of_graph connected between the DisplayPort > controller and a USB Type-C connector (or possibly a redriver). > > The TCPM needs to be able to convey the HPD signal to the DisplayPort > controller, but no directly link is provided by DeviceTree so the signal > needs to "pass through" the QMP combo phy. > > Handle this by introducing a drm_bridge which upon initialization finds > the next bridge (i.e. the usb-c-connector) and chain this together. This > way HPD changes in the connector will propagate to the DisplayPort > driver. > > The connector bridge is resolved lazily, as the TCPM is expected to be > able to resolve the typec mux and switch at probe time, so the QMP combo > phy will probe before the TCPM. > > Signed-off-by: Bjorn Andersson > Acked-by: Neil Armstrong > Tested-by: Bryan O'Donoghue > Reviewed-by: Bryan O'Donoghue > Tested-by: Abel Vesa > Tested-by: Steev Klimaszewski > Tested-by: Neil Armstrong # on HDK8450 > Tested-by: Johan Hovold # X13s > --- > > Changes since v1: > - Wrap DRM-related code in CONFIG_DRM guard > - Inroduce DRM-dependencies in Kconfig > - Dropped dev_err_probe() usage Reviewed-by: Johan Hovold