From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: SikkiLadho <mushi.shar@gmail.com>
Cc: mw@semihalf.com, linux-kernel@vger.kernel.org,
Ivan Orlov <ivan.orlov0322@gmail.com>
Subject: Re: [PATCH] net: marvell: fix error checking for debugfs
Date: Sat, 13 May 2023 10:59:43 +0100 [thread overview]
Message-ID: <ZF9fj9SEQbBLNgWB@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230513014628.39727-1-mushi.shar@gmail.com>
On Sat, May 13, 2023 at 06:46:28AM +0500, SikkiLadho wrote:
> This commit fixes error checking in by using IS_ERR inline function to
> check for errors.
>
> Suggested-by: Ivan Orlov <ivan.orlov0322@gmail.com>
> Signed-off-by: SikkiLadho <mushi.shar@gmail.com>
The modern wisdom for debugfs is not to check for any errors, so if
we're going to touch this, that's the route that any patch should be
taking.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2023-05-13 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-13 1:46 [PATCH] net: marvell: fix error checking for debugfs SikkiLadho
2023-05-13 9:59 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF9fj9SEQbBLNgWB@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ivan.orlov0322@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mushi.shar@gmail.com \
--cc=mw@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox