From: Dominique Martinet <asmadeus@codewreck.org>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
v9fs@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/9p: Remove INET dependency
Date: Tue, 2 May 2023 04:43:37 +0900 [thread overview]
Message-ID: <ZFAWaQbDR1_r5jf-@codewreck.org> (raw)
In-Reply-To: <20230501190602.86281-1-jandryuk@gmail.com>
Jason Andryuk wrote on Mon, May 01, 2023 at 03:06:00PM -0400:
> 9pfs can run over assorted transports, so it doesn't have an INET
> dependency. Drop it and remove the includes of linux/inet.h.
>
> This allows configuring 9pfs over Xen with INET disabled.
Good catch.
Could you add depends on INET to NET_9P_FD in net/9p/Kconfig?
That aside looks good to me; we probably ought to cleanup the includes a
bit more aggressively...
--
Dominique
next prev parent reply other threads:[~2023-05-01 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 19:06 [PATCH] fs/9p: Remove INET dependency Jason Andryuk
2023-05-01 19:43 ` Dominique Martinet [this message]
2023-05-02 12:03 ` Jason Andryuk
2023-05-02 23:31 ` Dominique Martinet
2023-05-03 14:11 ` Jason Andryuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFAWaQbDR1_r5jf-@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=jandryuk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).