From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EEBC77B73 for ; Tue, 2 May 2023 07:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231953AbjEBHUl (ORCPT ); Tue, 2 May 2023 03:20:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231915AbjEBHUj (ORCPT ); Tue, 2 May 2023 03:20:39 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B2957273A for ; Tue, 2 May 2023 00:20:37 -0700 (PDT) Received: (from willy@localhost) by mail.home.local (8.17.1/8.17.1/Submit) id 3427KaNZ028037; Tue, 2 May 2023 09:20:36 +0200 Date: Tue, 2 May 2023 09:20:36 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/nolibc: remove LINUX_REBOOT_ constants Message-ID: References: <20230428-nolibc-reboot-v1-1-0bca02d20ba6@weissschuh.net> <781b8ce2-bc3e-4eef-b466-fc0e26f64bb5@t-8ch.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <781b8ce2-bc3e-4eef-b466-fc0e26f64bb5@t-8ch.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 02, 2023 at 09:05:29AM +0200, Thomas Weißschuh wrote: > On 2023-05-02 08:59:27+0200, Willy Tarreau wrote: > > > > > > The following trivial fix on top of my patch would fix the problem: > > > > > > diff --git a/tools/include/nolibc/sys.h b/tools/include/nolibc/sys.h > > > index 5d624dc63a42..9d27131c224e 100644 > > > --- a/tools/include/nolibc/sys.h > > > +++ b/tools/include/nolibc/sys.h > > > @@ -21,6 +21,7 @@ > > > #include > > > #include // for O_* and AT_* > > > #include // for statx() > > > +#include // for LINUX_REBOOT_* > > > > > > #include "arch.h" > > > #include "errno.h" > > > > Indeed it works for me as well. > > > > > Want me to send a v2 or will you fix it up on your side? > > > > It depends. If for you it's a fix and needed for 6.4 (or maybe older), > > then that one is needed with the "//" comment, and it will later > > conflict with your previous cleanup patch that's already queued. If > > you're fine with having it queued for 6.5 only however, then I'll just > > edit your patch and add that above. I tend to think the second solution > > is sufficient given that nobody complained till now ;-) > > This is absolutely not urgent. 6.5 is fine. OK, now queued on top of my 20230415-nolibc-updates-4a branch that I'll soon send to Paul. Thank you! Willy