From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43506C77B73 for ; Tue, 2 May 2023 05:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233543AbjEBFxj (ORCPT ); Tue, 2 May 2023 01:53:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjEBFxg (ORCPT ); Tue, 2 May 2023 01:53:36 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EEFA2702 for ; Mon, 1 May 2023 22:53:35 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id BB6865C01EC; Tue, 2 May 2023 01:53:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 02 May 2023 01:53:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683006814; x=1683093214; bh=L2yccSjdHtS3v murCVuzHV7VToYRo/5t3+9/yGqQm7c=; b=GqVNG5J8PdJPsNqifSZuzBoQAg5dv 8JbQpHCnAbqZs6SERjZ/y4Yux9bUdOsNC53dqd4oHN/odG271Z4rgLBsAj+8MjIB L+ICrkD8P4LqZ0XeanU+N18/Mi6FC4iKCNfwcrlJ1ZlP1hfkbWwP1C9xC+EA9h0K fbm2vlAS/vgEbewbgiyMjkfync+ZCOoa8pXh2M2URvAzf3DD2hcM9oJlpEaXbIhq xHhHpHEDsVcSeR7TIjdhYA4TzzgK0fW8tL1icDbEqbxKsvobWFAyMozR/dCdJY6u 83G04ZFQlXGGnevGp6x9rJW6RVsbt4dt+32kJs48IBB7Hz/ZOxYYbOOGA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvhedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkugho ucfutghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrg htthgvrhhnpedvudefveekheeugeeftddvveefgfduieefudeifefgleekheegleegjeej geeghfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 May 2023 01:53:33 -0400 (EDT) Date: Tue, 2 May 2023 08:53:29 +0300 From: Ido Schimmel To: Thomas Gleixner Cc: Schspa Shi , longman@redhat.com, swboyd@chromium.org, linux@roeck-us.net, wuchi.zero@gmail.com, linux-kernel@vger.kernel.org, syzbot+5093ba19745994288b53@syzkaller.appspotmail.com, danieller@nvidia.com, petrm@nvidia.com Subject: Re: [PATCH] debugobject: Prevent init race with static objects Message-ID: References: <20230303161906.831686-1-schspa@gmail.com> <87bkl9jt3a.ffs@tglx> <87sfdw8yru.ffs@tglx> <87pm908xvu.ffs@tglx> <87zg7dzgao.ffs@tglx> <871qk05a9d.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qk05a9d.ffs@tglx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 01, 2023 at 05:42:06PM +0200, Thomas Gleixner wrote: > The change in that patch is neither debug_objects_activate() nor > debug_objecs_assert_init() no longer invoke debug_object_init() which is > now the only place doing pool refills. So depending on the number of > statically allocated objects this might deplete the pool quick enough. > > Does the patch below restore the old behaviour? Yes. Couldn't reproduce the issue with the proposed fix. Feel free to add: Tested-by: Ido Schimmel Thanks for the quick fix!