public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tools/nolibc: Implement WTERMSIG()
@ 2023-04-28 15:24 Mark Brown
  2023-05-02  6:20 ` Willy Tarreau
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2023-04-28 15:24 UTC (permalink / raw)
  To: Willy Tarreau, Paul E. McKenney; +Cc: linux-kernel, Mark Brown

Add an implementation of WTERMSIG() to allow nolibc programs to obtain the
signal that caused the exit of a process, and use it in WIFEXITED() since
the condition being checked there is that no signal was reported.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 tools/include/nolibc/types.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/include/nolibc/types.h b/tools/include/nolibc/types.h
index fbbc0e68c001..eb0b9f1ffe18 100644
--- a/tools/include/nolibc/types.h
+++ b/tools/include/nolibc/types.h
@@ -79,8 +79,9 @@
 #define LINUX_REBOOT_CMD_SW_SUSPEND 0xd000fce2
 
 /* Macros used on waitpid()'s return status */
+#define WTERMSIG(status)    ((status) & 0x7f)
 #define WEXITSTATUS(status) (((status) & 0xff00) >> 8)
-#define WIFEXITED(status)   (((status) & 0x7f) == 0)
+#define WIFEXITED(status)   (WTERMSIG(status) == 0)
 
 /* waitpid() flags */
 #define WNOHANG      1

---
base-commit: 457391b0380335d5e9a5babdec90ac53928b23b4
change-id: 20230427-nolibc-wtermsig-95c5d064f949

Best regards,
-- 
Mark Brown <broonie@kernel.org>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tools/nolibc: Implement WTERMSIG()
  2023-04-28 15:24 [PATCH] tools/nolibc: Implement WTERMSIG() Mark Brown
@ 2023-05-02  6:20 ` Willy Tarreau
  0 siblings, 0 replies; 2+ messages in thread
From: Willy Tarreau @ 2023-05-02  6:20 UTC (permalink / raw)
  To: Mark Brown; +Cc: Paul E. McKenney, linux-kernel

Hi Mark,

On Fri, Apr 28, 2023 at 04:24:36PM +0100, Mark Brown wrote:
> Add an implementation of WTERMSIG() to allow nolibc programs to obtain the
> signal that caused the exit of a process, and use it in WIFEXITED() since
> the condition being checked there is that no signal was reported.

Thanks, but Thomas already submitted a similar one that's already queued
for 6.5 in Paul's rcu tree:

  https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?h=dev.2023.04.26b&id=8c934d4822c77818d53f5f4c948c3ace6fda1505

At least it further emphasizes the fact that the patch is needed ;-)

Thanks!
Willy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-02  6:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-28 15:24 [PATCH] tools/nolibc: Implement WTERMSIG() Mark Brown
2023-05-02  6:20 ` Willy Tarreau

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox