Re: [PATCH 0/7] phy: qcom-qmp-combo: Support orientation switching

Johan Hovold
2023-05-02T12:26:31Z

On Mon, Apr 24, 2023 at 08:40:03PM -0700, Bjorn Andersson wrote:
> This adds support for USB and DisplayPort orientation switching to the
> QMP combo PHY, as well as updating the sc8280xp devices to include the
> QMP in the SuperSpeed graph.

Nice and clean series!

I've tested it a bit on the X13s and verified that DP works on both
ports and in both orientations. Coldplug also appears to work reliably.

Tested-by: Johan Hovold <johan+linaro@kernel.org> # X13s

> Bjorn Andersson (7):
> dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp: Add ports and
> orientation-switch
> phy: qcom-qmp-combo: Move phy_mutex out of com_init/exit
> phy: qcom-qmp-combo: Introduce orientation variable
> phy: qcom-qmp-combo: Introduce orientation switching
> phy: qcom-qmp-combo: Introduce drm_bridge
> arm64: dts: qcom: sc8280xp-crd: Add QMP to SuperSpeed graph
> arm64: dts: qcom: sc8280xp-x13s: Add QMP to SuperSpeed graph
>
> .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 51 ++++
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 28 ++-
> .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 28 ++-
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 34 +++
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 227 ++++++++++++++----
> 5 files changed, 309 insertions(+), 59 deletions(-)

Johan