Re: [PATCH v4 2/3] iio: pressure: Honeywell mprls0025pa pressure sensor

Jonathan Cameron
2023-05-20T16:19:33Z

On Tue, 16 May 2023 12:28:18 +0200
Andreas Klinger <ak@it-klinger.de> wrote:

> Hi Jonathan,
>
> thanks for your review. I have one comment.
>
> Jonathan Cameron <jic23@kernel.org> schrieb am Sa, 06. Mai 17:04:
> > > + int scale; /* int part of scale */
> > > + int scale2; /* nano part of scale */
> > > + int offset; /* int part of offset */
> > > + int offset2; /* nano part of offset */
> > > + struct gpio_desc *gpiod_reset; /* reset */
> > > + int irq; /* end of conversion irq */
> >
> > Only needed in probe, no need for a copy in here.
>
> It's also used in mpr_read_pressure() to distinguish the two possible operation
> modes:
> - waiting for an interrupt
> - reading in a loop until status indicates data ready
>
Oops. Thanks for pointing that out!

> Andreas