From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0396FC77B7D for ; Fri, 5 May 2023 20:35:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbjEEUf1 (ORCPT ); Fri, 5 May 2023 16:35:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbjEEUf0 (ORCPT ); Fri, 5 May 2023 16:35:26 -0400 Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2601A49E7 for ; Fri, 5 May 2023 13:35:24 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 5addbdeb-eb84-11ed-b3cf-005056bd6ce9; Fri, 05 May 2023 23:35:21 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Fri, 5 May 2023 23:35:21 +0300 To: Oleksii Moisieiev Cc: "sudeep.holla@arm.com" , Linus Walleij , Cristian Marussi , Peng Fan , Michal Simek , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" Subject: Re: [RFC v2 2/3] pinctrl: Implementation of the generic scmi-pinctrl driver Message-ID: References: <812ae71d017b115c55648dbf0a4c3502715b1955.1682513390.git.oleksii_moisieiev@epam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <812ae71d017b115c55648dbf0a4c3502715b1955.1682513390.git.oleksii_moisieiev@epam.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Apr 26, 2023 at 01:26:37PM +0000, Oleksii Moisieiev kirjoitti: > scmi-pinctrl driver implements pinctrl driver interface and using > SCMI protocol to redirect messages from pinctrl subsystem SDK to > SCP firmware, which does the changes in HW. > > This setup expects SCP firmware (or similar system, such as ATF) > to be installed on the platform, which implements pinctrl driver > for the specific platform. > > SCMI-Pinctrl driver should be configured from the device-tree and uses > generic device-tree mappings for the configuration. ... > +#include > +#include > +#include I do not see any user of this header. Do you? > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include Please, move these two to the upper group of the generic headers. > +struct scmi_pinctrl_funcs { > + unsigned int num_groups; > + const char **groups; > +}; Please, use struct pinfunction. ... > +struct scmi_pinctrl { > + struct scmi_pinctrl_funcs *functions; > + unsigned int nr_functions; > + char **groups; > + unsigned int nr_groups; I'm not sure what is the difference to what "functions" above represent. > +}; ... > +static void pinctrl_scmi_pin_dbg_show(struct pinctrl_dev *pctldev, > + struct seq_file *s, > + unsigned int offset) > +{ > + seq_puts(s, DRV_NAME); > +} What is the usefulness of this method? ... > +static int pinctrl_scmi_pinconf_group_get(struct pinctrl_dev *pctldev, > + unsigned int _pin, > + unsigned long *config) > +{ > + int ret; > + struct scmi_pinctrl *pmx; > + enum pin_config_param config_type; > + unsigned long config_value; > + > + if (!pctldev) > + return -EINVAL; > + > + pmx = pinctrl_dev_get_drvdata(pctldev); > + > + if (!pmx || !pmx->ph || !config) > + return -EINVAL; > + > + config_type = pinconf_to_config_param(*config); > + > + ret = pinctrl_ops->get_config(pmx->ph, _pin, GROUP_TYPE, > + config_type, (u32 *)&config_value); Endianess issue. This is, while likely working code, still ugly. > + if (ret) > + return ret; > + > + *config = pinconf_to_config_packed(config_type, config_value); > + > + return 0; > +} ... > + err: err_free. > + kfree(pmx->pins); > + pmx->nr_pins = 0; > + > + return ret; ... > +static const struct scmi_device_id scmi_id_table[] = { > + { SCMI_PROTOCOL_PINCTRL, "pinctrl" }, > + { }, No comma for the terminator entry. > +}; ... > + pinctrl_ops = handle->devm_protocol_get(sdev, SCMI_PROTOCOL_PINCTRL, > + &ph); Can be on one line. > + if (IS_ERR(pinctrl_ops)) > + return PTR_ERR(pinctrl_ops); ... > + if (pmx->nr_functions) { > + pmx->functions = > + devm_kcalloc(&sdev->dev, pmx->nr_functions, > + sizeof(*pmx->functions), > + GFP_KERNEL); > + if (!pmx->functions) { > + ret = -ENOMEM; > + goto clean; Interleaving devm_*() with non-devm_*() in such order is not a good idea. > + } > + } > + > + if (pmx->nr_groups) { > + pmx->groups = > + devm_kcalloc(&sdev->dev, pmx->nr_groups, > + sizeof(*pmx->groups), > + GFP_KERNEL); > + if (!pmx->groups) { > + ret = -ENOMEM; > + goto clean; > + } > + } > + > + return pinctrl_enable(pmx->pctldev); > + > +clean: err_free: > + if (pmx) { > + kfree(pmx->functions); > + kfree(pmx->groups); Ah, this is simply wrong. > + } > + > + kfree(pmx); -- With Best Regards, Andy Shevchenko