From: Simon Horman <horms@kernel.org>
To: Md Danish Anwar <a0501179@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev
Subject: Re: [PATCH] soc: ti: pruss: Avoid cast to incompatible function type
Date: Mon, 8 May 2023 15:45:33 +0200 [thread overview]
Message-ID: <ZFj8/TW1bMuqY1WP@kernel.org> (raw)
In-Reply-To: <f6c92e55-93f5-e5c6-e5ca-4c24fd59f245@ti.com>
On Thu, Apr 20, 2023 at 11:19:59AM +0530, Md Danish Anwar wrote:
> On 18/04/23 17:11, Simon Horman wrote:
...
> > Rather than casting clk_unregister_mux to an incompatible function
> > type provide a trivial wrapper with the correct signature for the
> > use-case.
> >
> > Reported by clang-16 with W=1:
> >
> > drivers/soc/ti/pruss.c:158:38: error: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
> > ret = devm_add_action_or_reset(dev, (void(*)(void *))clk_unregister_mux,
> >
> > No functional change intended.
> > Compile tested only.
> >
> > Signed-off-by: Simon Horman <horms@kernel.org>
>
> Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
Hi,
I'm wondering what the path of this patch to Linus's tree might be.
Perhaps naively, I expected it to show up in v6.4-rc1.
next prev parent reply other threads:[~2023-05-08 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 11:41 [PATCH] soc: ti: pruss: Avoid cast to incompatible function type Simon Horman
2023-04-18 18:44 ` Nick Desaulniers
2023-04-19 5:45 ` Simon Horman
2023-04-18 18:44 ` Nathan Chancellor
2023-04-20 5:49 ` Md Danish Anwar
2023-05-08 13:45 ` Simon Horman [this message]
2023-05-17 17:55 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFj8/TW1bMuqY1WP@kernel.org \
--to=horms@kernel.org \
--cc=a0501179@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox