Re: [PATCH 35/40] lib: implement context capture support for tagged allocations

Suren Baghdasaryan
2023-05-03T15:24:38Z

On Wed, May 3, 2023 at 12:39 AM Michal Hocko <mhocko@suse.com> wrote:
>
> On Mon 01-05-23 09:54:45, Suren Baghdasaryan wrote:
> [...]
> > +struct codetag_ctx *alloc_tag_create_ctx(struct alloc_tag *tag, size_t size)
> > +{
> > + struct alloc_call_ctx *ac_ctx;
> > +
> > + /* TODO: use a dedicated kmem_cache */
> > + ac_ctx = kmalloc(sizeof(struct alloc_call_ctx), GFP_KERNEL);
>
> You cannot really use GFP_KERNEL here. This is post_alloc_hook path and
> that has its own gfp context.

I missed that. Would it be appropriate to use the gfp_flags parameter
of post_alloc_hook() here?

> --
> Michal Hocko
> SUSE Labs