From: James Seo <james@equiv.tech>
To: Randy Dunlap <rdunlap@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: James Seo <james@equiv.tech>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: device.h: add some missing kerneldocs
Date: Mon, 8 May 2023 18:51:20 -0700 [thread overview]
Message-ID: <ZFmnGGzcTPdrvJrn@equiv.tech> (raw)
In-Reply-To: <0a75a41e-6458-8f7a-67cd-89eb05eb822f@infradead.org>
On Mon, May 08, 2023 at 11:55:47AM -0700, Randy Dunlap wrote:
> On 5/8/23 09:13, James Seo wrote:
>> On Mon, May 08, 2023 at 08:48:50AM -0700, James Seo wrote:
>>> Add the missing kerneldocs (except for DEVICE_ATTR_IGNORE_LOCKDEP(),
>>> which is only meaningful on debug builds with CONFIG_DEBUG_LOCK_ALLOC
>>> not #defined, and is aliased to DEVICE_ATTR() otherwise).
>>>
>>> Signed-off-by: James Seo <james@equiv.tech>
>>> ---
>>
>> I just noticed that there shouldn't be a "not" before "#defined" in the
>> last line of the commit message. Apologies.
>>
>
> Other than that (above), LGTM.
>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> --
> ~Randy
Thanks for the review!
Just to be clear, that line should read "defined, and is aliased to..."
as commit messages can't have lines that begin with '#'.
James
next prev parent reply other threads:[~2023-05-09 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 15:48 [PATCH] driver core: device.h: add some missing kerneldocs James Seo
2023-05-08 16:13 ` James Seo
2023-05-08 18:55 ` Randy Dunlap
2023-05-09 1:51 ` James Seo [this message]
2023-05-09 2:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFmnGGzcTPdrvJrn@equiv.tech \
--to=james@equiv.tech \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox