* [PATCH] parisc: kexec: include reboot.h
@ 2023-05-09 7:01 Simon Horman
2023-05-09 9:01 ` Baoquan He
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2023-05-09 7:01 UTC (permalink / raw)
To: James E.J. Bottomley, Helge Deller
Cc: Baoquan He, Leizhen (ThunderTown), kexec, linux-parisc,
linux-kernel
Include reboot.h in machine_kexec.c for declaration of
machine_crash_shutdown and machine_shutdown.
gcc-12 with W=1 reports:
arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
57 | void machine_crash_shutdown(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~~~~
arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
61 | void machine_shutdown(void)
| ^~~~~~~~~~~~~~~~
No functional changes intended.
Compile tested only.
Signed-off-by: Simon Horman <horms@kernel.org>
---
arch/parisc/kernel/kexec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/parisc/kernel/kexec.c b/arch/parisc/kernel/kexec.c
index 5eb7f30edc1f..db57345a9daf 100644
--- a/arch/parisc/kernel/kexec.c
+++ b/arch/parisc/kernel/kexec.c
@@ -4,6 +4,8 @@
#include <linux/console.h>
#include <linux/kexec.h>
#include <linux/delay.h>
+#include <linux/reboot.h>
+
#include <asm/cacheflush.h>
#include <asm/sections.h>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] parisc: kexec: include reboot.h
2023-05-09 7:01 [PATCH] parisc: kexec: include reboot.h Simon Horman
@ 2023-05-09 9:01 ` Baoquan He
2023-05-09 11:52 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Baoquan He @ 2023-05-09 9:01 UTC (permalink / raw)
To: Simon Horman
Cc: James E.J. Bottomley, Helge Deller, Leizhen (ThunderTown), kexec,
linux-parisc, linux-kernel
On 05/09/23 at 09:01am, Simon Horman wrote:
> Include reboot.h in machine_kexec.c for declaration of
> machine_crash_shutdown and machine_shutdown.
>
> gcc-12 with W=1 reports:
>
> arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
> 57 | void machine_crash_shutdown(struct pt_regs *regs)
> | ^~~~~~~~~~~~~~~~~~~~~~
> arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
> 61 | void machine_shutdown(void)
> | ^~~~~~~~~~~~~~~~
>
> No functional changes intended.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@kernel.org>
Acked-by: Baoquan He <bhe@redhat.com>
We may need to find out the places in all architectures and fix all of
them.
> ---
> arch/parisc/kernel/kexec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/parisc/kernel/kexec.c b/arch/parisc/kernel/kexec.c
> index 5eb7f30edc1f..db57345a9daf 100644
> --- a/arch/parisc/kernel/kexec.c
> +++ b/arch/parisc/kernel/kexec.c
> @@ -4,6 +4,8 @@
> #include <linux/console.h>
> #include <linux/kexec.h>
> #include <linux/delay.h>
> +#include <linux/reboot.h>
> +
> #include <asm/cacheflush.h>
> #include <asm/sections.h>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] parisc: kexec: include reboot.h
2023-05-09 9:01 ` Baoquan He
@ 2023-05-09 11:52 ` Simon Horman
2023-05-09 12:08 ` Helge Deller
2023-05-10 4:11 ` Baoquan He
0 siblings, 2 replies; 5+ messages in thread
From: Simon Horman @ 2023-05-09 11:52 UTC (permalink / raw)
To: Baoquan He
Cc: James E.J. Bottomley, Helge Deller, Leizhen (ThunderTown), kexec,
linux-parisc, linux-kernel
On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote:
> On 05/09/23 at 09:01am, Simon Horman wrote:
> > Include reboot.h in machine_kexec.c for declaration of
> > machine_crash_shutdown and machine_shutdown.
> >
> > gcc-12 with W=1 reports:
> >
> > arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
> > 57 | void machine_crash_shutdown(struct pt_regs *regs)
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
> > 61 | void machine_shutdown(void)
> > | ^~~~~~~~~~~~~~~~
> >
> > No functional changes intended.
> > Compile tested only.
> >
> > Signed-off-by: Simon Horman <horms@kernel.org>
>
> Acked-by: Baoquan He <bhe@redhat.com>
>
> We may need to find out the places in all architectures and fix all of
> them.
I did check. It seemed to be needed for riscv, m68k and parisc.
I've sent out patches for all three. But I may have missed something.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] parisc: kexec: include reboot.h
2023-05-09 11:52 ` Simon Horman
@ 2023-05-09 12:08 ` Helge Deller
2023-05-10 4:11 ` Baoquan He
1 sibling, 0 replies; 5+ messages in thread
From: Helge Deller @ 2023-05-09 12:08 UTC (permalink / raw)
To: Simon Horman, Baoquan He
Cc: James E.J. Bottomley, Leizhen (ThunderTown), kexec, linux-parisc,
linux-kernel
On 5/9/23 13:52, Simon Horman wrote:
> On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote:
>> On 05/09/23 at 09:01am, Simon Horman wrote:
>>> Include reboot.h in machine_kexec.c for declaration of
>>> machine_crash_shutdown and machine_shutdown.
>>>
>>> gcc-12 with W=1 reports:
>>>
>>> arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
>>> 57 | void machine_crash_shutdown(struct pt_regs *regs)
>>> | ^~~~~~~~~~~~~~~~~~~~~~
>>> arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
>>> 61 | void machine_shutdown(void)
>>> | ^~~~~~~~~~~~~~~~
>>>
>>> No functional changes intended.
>>> Compile tested only.
>>>
>>> Signed-off-by: Simon Horman <horms@kernel.org>
>>
>> Acked-by: Baoquan He <bhe@redhat.com>
applied to parisc for-next git tree.
Thanks!
Helge
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] parisc: kexec: include reboot.h
2023-05-09 11:52 ` Simon Horman
2023-05-09 12:08 ` Helge Deller
@ 2023-05-10 4:11 ` Baoquan He
1 sibling, 0 replies; 5+ messages in thread
From: Baoquan He @ 2023-05-10 4:11 UTC (permalink / raw)
To: Simon Horman
Cc: James E.J. Bottomley, Helge Deller, Leizhen (ThunderTown), kexec,
linux-parisc, linux-kernel
On 05/09/23 at 01:52pm, Simon Horman wrote:
> On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote:
> > On 05/09/23 at 09:01am, Simon Horman wrote:
> > > Include reboot.h in machine_kexec.c for declaration of
> > > machine_crash_shutdown and machine_shutdown.
> > >
> > > gcc-12 with W=1 reports:
> > >
> > > arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
> > > 57 | void machine_crash_shutdown(struct pt_regs *regs)
> > > | ^~~~~~~~~~~~~~~~~~~~~~
> > > arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
> > > 61 | void machine_shutdown(void)
> > > | ^~~~~~~~~~~~~~~~
> > >
> > > No functional changes intended.
> > > Compile tested only.
> > >
> > > Signed-off-by: Simon Horman <horms@kernel.org>
> >
> > Acked-by: Baoquan He <bhe@redhat.com>
> >
> > We may need to find out the places in all architectures and fix all of
> > them.
>
> I did check. It seemed to be needed for riscv, m68k and parisc.
> I've sent out patches for all three. But I may have missed something.
That's great, thanks. I didn't notice the other two.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-10 4:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-09 7:01 [PATCH] parisc: kexec: include reboot.h Simon Horman
2023-05-09 9:01 ` Baoquan He
2023-05-09 11:52 ` Simon Horman
2023-05-09 12:08 ` Helge Deller
2023-05-10 4:11 ` Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox