From: Mark Rutland <mark.rutland@arm.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Will Deacon <will@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] ARM/arm64: Mark all accessor functions inline
Date: Tue, 9 May 2023 12:30:29 +0100 [thread overview]
Message-ID: <ZFou1SdT8SQaqpQu@FVFF77S0Q05N> (raw)
In-Reply-To: <cover.1683561087.git.geert+renesas@glider.be>
On Mon, May 08, 2023 at 06:05:17PM +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series adds missing "inline" keywords to the few perf
> accessors that lack them.
Will, I assume that you'll pick these up as a cleanup/fix.
Thanks,
Mark.
> BTW, I tried converting my local timing code to the new unified system.
> This works fine on arm64, but broke on arm32. Is read_pmccntr()
> supposed to work on arm32? I get an undefined instruction exception on
> Cortex A15 and A9. Before, my custom code used "mrc p15, 0, %0, c9,
> c13, 0" (as is also used in arch/arm/kernel/perf_event_v7.c), for which
> there is no accessor yet.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (2):
> ARM: perf: Mark all accessor functions inline
> arm64: perf: Mark all accessor functions inline
>
> arch/arm/include/asm/arm_pmuv3.h | 6 +++---
> arch/arm64/include/asm/arm_pmuv3.h | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> --
> 2.34.1
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2023-05-09 11:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 16:05 [PATCH 0/2] ARM/arm64: Mark all accessor functions inline Geert Uytterhoeven
2023-05-08 16:05 ` [PATCH 1/2] ARM: perf: " Geert Uytterhoeven
2023-05-08 16:05 ` [PATCH 2/2] arm64: " Geert Uytterhoeven
2023-05-09 7:55 ` Marc Zyngier
2023-05-09 11:28 ` Mark Rutland
2023-05-09 7:56 ` [PATCH 1/2] ARM: " Marc Zyngier
2023-05-09 11:27 ` Mark Rutland
2023-05-09 7:42 ` [PATCH 0/2] ARM/arm64: " Marc Zyngier
2023-05-09 11:26 ` Mark Rutland
2023-05-09 11:30 ` Mark Rutland [this message]
2023-05-16 15:14 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFou1SdT8SQaqpQu@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox