From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15BD6C77B75 for ; Tue, 9 May 2023 11:28:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235522AbjEIL2O (ORCPT ); Tue, 9 May 2023 07:28:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235342AbjEIL2M (ORCPT ); Tue, 9 May 2023 07:28:12 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BEE972D49 for ; Tue, 9 May 2023 04:28:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05BAEFEC; Tue, 9 May 2023 04:28:55 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.56.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 53A493F67D; Tue, 9 May 2023 04:28:09 -0700 (PDT) Date: Tue, 9 May 2023 12:28:06 +0100 From: Mark Rutland To: Geert Uytterhoeven Cc: Marc Zyngier , Russell King , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: perf: Mark all accessor functions inline Message-ID: References: <3a7d9bc7470aa2d85696ee9765c74f8c03fb5454.1683561482.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 08, 2023 at 06:05:19PM +0200, Geert Uytterhoeven wrote: > When just including : > > arch/arm64/include/asm/arm_pmuv3.h:31:13: error: ‘write_pmevtypern’ defined but not used [-Werror=unused-function] > 31 | static void write_pmevtypern(int n, unsigned long val) > | ^~~~~~~~~~~~~~~~ > arch/arm64/include/asm/arm_pmuv3.h:24:13: error: ‘write_pmevcntrn’ defined but not used [-Werror=unused-function] > 24 | static void write_pmevcntrn(int n, unsigned long val) > | ^~~~~~~~~~~~~~~ > arch/arm64/include/asm/arm_pmuv3.h:16:22: error: ‘read_pmevcntrn’ defined but not used [-Werror=unused-function] > 16 | static unsigned long read_pmevcntrn(int n) > | ^~~~~~~~~~~~~~ > > Fix this by adding the missing "inline" keywords to the three accessor > functions that lack them. > > Fixes: df29ddf4f04b00cf ("arm64: perf: Abstract system register accesses away") > Signed-off-by: Geert Uytterhoeven Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/arm_pmuv3.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/include/asm/arm_pmuv3.h b/arch/arm64/include/asm/arm_pmuv3.h > index d6b51deb7bf0ff2f..18dc2fb3d7b7b2d0 100644 > --- a/arch/arm64/include/asm/arm_pmuv3.h > +++ b/arch/arm64/include/asm/arm_pmuv3.h > @@ -13,7 +13,7 @@ > > #define RETURN_READ_PMEVCNTRN(n) \ > return read_sysreg(pmevcntr##n##_el0) > -static unsigned long read_pmevcntrn(int n) > +static inline unsigned long read_pmevcntrn(int n) > { > PMEVN_SWITCH(n, RETURN_READ_PMEVCNTRN); > return 0; > @@ -21,14 +21,14 @@ static unsigned long read_pmevcntrn(int n) > > #define WRITE_PMEVCNTRN(n) \ > write_sysreg(val, pmevcntr##n##_el0) > -static void write_pmevcntrn(int n, unsigned long val) > +static inline void write_pmevcntrn(int n, unsigned long val) > { > PMEVN_SWITCH(n, WRITE_PMEVCNTRN); > } > > #define WRITE_PMEVTYPERN(n) \ > write_sysreg(val, pmevtyper##n##_el0) > -static void write_pmevtypern(int n, unsigned long val) > +static inline void write_pmevtypern(int n, unsigned long val) > { > PMEVN_SWITCH(n, WRITE_PMEVTYPERN); > } > -- > 2.34.1 >