From: Simon Horman <simon.horman@corigine.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, "Doug Berger" <opendmb@gmail.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Marek Behún" <kabel@kernel.org>,
"Peter Geis" <pgwipeout@gmail.com>,
Frank <Frank.Sae@motor-comm.com>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 1/3] net: phy: Allow drivers to always call into ->suspend()
Date: Thu, 11 May 2023 12:10:11 +0200 [thread overview]
Message-ID: <ZFy/A9vuxBl7WKt9@corigine.com> (raw)
In-Reply-To: <20230509223403.1852603-2-f.fainelli@gmail.com>
On Tue, May 09, 2023 at 03:34:01PM -0700, Florian Fainelli wrote:
> A few PHY drivers are currently attempting to not suspend the PHY when
> Wake-on-LAN is enabled, however that code is not currently executing at
> all due to an early check in phy_suspend().
>
> This prevents PHY drivers from making an appropriate decisions and put
> the hardware into a low power state if desired.
>
> In order to allow the PHY drivers to opt into getting their ->suspend
> routine to be called, add a PHY_ALWAYS_CALL_SUSPEND bit which can be
> set. A boolean that tracks whether the PHY or the attached MAC has
> Wake-on-LAN enabled is also provided for convenience.
>
> If phydev::wol_enabled then the PHY shall not prevent its own
> Wake-on-LAN detection logic from working and shall not prevent the
> Ethernet MAC from receiving packets for matching.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-05-11 10:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 22:34 [PATCH net-next v2 0/3] Support for Wake-on-LAN for Broadcom Florian Fainelli
2023-05-09 22:34 ` [PATCH net-next v2 1/3] net: phy: Allow drivers to always call into ->suspend() Florian Fainelli
2023-05-11 10:10 ` Simon Horman [this message]
2023-05-11 12:08 ` Andrew Lunn
2023-05-09 22:34 ` [PATCH net-next v2 2/3] net: phy: broadcom: Add support for Wake-on-LAN Florian Fainelli
2023-05-11 10:10 ` Simon Horman
2023-05-11 10:26 ` Paolo Abeni
2023-05-11 16:17 ` Florian Fainelli
2023-05-09 22:34 ` [PATCH net-next v2 3/3] net: bcmgenet: Add support for PHY-based Wake-on-LAN Florian Fainelli
2023-05-11 10:10 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFy/A9vuxBl7WKt9@corigine.com \
--to=simon.horman@corigine.com \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox