From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhangjin Wu <falcon@tinylab.org>
Subject: Re: [PATCH 0/3] tools/nolibc: stack protector compatibility fixes
Date: Wed, 24 May 2023 09:35:30 +0200 [thread overview]
Message-ID: <ZG2+QuD/tVDqyMyb@1wt.eu> (raw)
In-Reply-To: <20230523-nolibc-stackprotector-gcc9-v1-0-3e4804235d50@weissschuh.net>
Hi Thomas,
On Wed, May 24, 2023 at 08:44:41AM +0200, Thomas Weißschuh wrote:
> Two fixes for nolibc to
> * allow users to explicitly disable (or theoretically enable) when
> building the tests
> * fix stackprotectors on GCC < 10.
Nice, thank you. Just tested with gcc 9.5, works both with and without
stkp. Now pushed to branch 20230524-nolibc-rv32+stkp4. I've dropped my
exp patch and the associated revert. I think your two patches that clean
up the makefile options and the new one here that restores the cflags
should be squashed since the latter just partially reverts the former,
and that way the series remains bisectable. Just let me know if you're
OK, I can just to that and re-push.
Have a nice day!
Willy
next prev parent reply other threads:[~2023-05-24 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 6:44 [PATCH 0/3] tools/nolibc: stack protector compatibility fixes Thomas Weißschuh
2023-05-24 6:44 ` [PATCH 1/3] Revert "EXP: tools/nolibc: partially revert stackprotector compiler flags" Thomas Weißschuh
2023-05-24 6:44 ` [PATCH 2/3] selftests/nolibc: allow disabling of stackprotector support Thomas Weißschuh
2023-05-24 6:44 ` [PATCH 3/3] tools/nolibc: fix segfaults on compilers without attribute no_stack_protector Thomas Weißschuh
2023-05-24 7:35 ` Willy Tarreau [this message]
2023-05-24 7:38 ` [PATCH 0/3] tools/nolibc: stack protector compatibility fixes Thomas Weißschuh
2023-05-24 7:56 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG2+QuD/tVDqyMyb@1wt.eu \
--to=w@1wt.eu \
--cc=falcon@tinylab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox