From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE598C7EE32 for ; Wed, 24 May 2023 07:36:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235059AbjEXHgM (ORCPT ); Wed, 24 May 2023 03:36:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239258AbjEXHgI (ORCPT ); Wed, 24 May 2023 03:36:08 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 21F3E135; Wed, 24 May 2023 00:35:50 -0700 (PDT) Received: (from willy@localhost) by mail.home.local (8.17.1/8.17.1/Submit) id 34O7ZUQg018960; Wed, 24 May 2023 09:35:30 +0200 Date: Wed, 24 May 2023 09:35:30 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Zhangjin Wu Subject: Re: [PATCH 0/3] tools/nolibc: stack protector compatibility fixes Message-ID: References: <20230523-nolibc-stackprotector-gcc9-v1-0-3e4804235d50@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230523-nolibc-stackprotector-gcc9-v1-0-3e4804235d50@weissschuh.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On Wed, May 24, 2023 at 08:44:41AM +0200, Thomas Weißschuh wrote: > Two fixes for nolibc to > * allow users to explicitly disable (or theoretically enable) when > building the tests > * fix stackprotectors on GCC < 10. Nice, thank you. Just tested with gcc 9.5, works both with and without stkp. Now pushed to branch 20230524-nolibc-rv32+stkp4. I've dropped my exp patch and the associated revert. I think your two patches that clean up the makefile options and the new one here that restores the cflags should be squashed since the latter just partially reverts the former, and that way the series remains bisectable. Just let me know if you're OK, I can just to that and re-push. Have a nice day! Willy