From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F69CC77B7A for ; Thu, 25 May 2023 09:43:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232968AbjEYJnX (ORCPT ); Thu, 25 May 2023 05:43:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240455AbjEYJnU (ORCPT ); Thu, 25 May 2023 05:43:20 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0A27191 for ; Thu, 25 May 2023 02:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GTCv05NKX7fYVfcWA9mF9yBEXPLxaqPCHQmLNCv1ZJQ=; b=TJQ/U68WU/s2VYiJ/03J7kmoh+ YblMToMJpjlLY+OOjtRXYhlbHukydmw3PUftGnI27aU1oJMzLVXvU3OYxSMvMHmhEtzU0tY9KhA/K mMDtIgHzw0Us/B5mctq1KmB0zDiCzIW8QQl2oo8eWAlFZnvsVmRgQWnbRpEkwzys0xhzTWdTEzcsR CJ/kw8rEjWcpI1k4GxbDPAuQDGGSTcR62w2b3jTFlXr+17TQyG7fVzVmJ5ur1bFaa/RL0UA8MRnYC 8KZaYVgF8Fb5kNlHNEvEHQ8QlrrZM88RmzzNDbkzeYR6tJsKXJ0twKVQXskmpLGw6kXepWjIlJFX4 UWb9YshA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q27V6-00GBCU-2n; Thu, 25 May 2023 09:43:16 +0000 Date: Thu, 25 May 2023 02:43:16 -0700 From: Christoph Hellwig To: Hamza Mahfooz Cc: amd-gfx@lists.freedesktop.org, Alex Deucher , Harry Wentland , Kenny Ho , Leo Li , Rodrigo Siqueira , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks Message-ID: References: <20230524191955.252212-1-hamza.mahfooz@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230524191955.252212-1-hamza.mahfooz@amd.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation We have a config option for -Werror. Blindly adding this will create problems with too new (or sometimes too old, or just too weird) compilers all the time. Don't do this.