From: Keith Busch <kbusch@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/5] nvmet: Reorder fields in 'struct nvme_ctrl'
Date: Mon, 15 May 2023 08:21:28 -0600 [thread overview]
Message-ID: <ZGI/6DT30JBfQPnG@kbusch-mbp> (raw)
In-Reply-To: <af016d2a5e7e7bb503eadb15037b80bc9813b94c.1682941568.git.christophe.jaillet@wanadoo.fr>
On Mon, May 01, 2023 at 02:40:26PM +0200, Christophe JAILLET wrote:
> Group some variables based on their sizes to reduce holes.
> On x86_64, this shrinks the size of 'struct nvmet_sq' from 5368 to 5344
> bytes when all CONFIG_* are defined.
This patch is changing struct nvme_ctrl but the commit log only mentions
struct nvmet_sq, which was handled in patch 1/5. I'll just fix that up
when applying.
> This structure is embedded into some other structures, so it helps reducing
> their size as well.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Using pahole
>
> Before:
> ======
> struct nvme_ctrl {
> bool comp_seen; /* 0 1 */
next prev parent reply other threads:[~2023-05-15 14:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 12:40 [PATCH 0/5] optimize some data structure in nvme Christophe JAILLET
2023-05-01 12:40 ` [PATCH 1/5] nvmet: Reorder fields in 'struct nvmet_sq' Christophe JAILLET
2023-05-01 12:40 ` [PATCH 2/5] nvmet: Reorder fields in 'struct nvme_ctrl' Christophe JAILLET
2023-05-15 14:21 ` Keith Busch [this message]
2023-05-15 17:22 ` Christophe JAILLET
2023-05-01 12:40 ` [PATCH 3/5] nvmet: Reorder fields in 'struct nvmf_ctrl_options' Christophe JAILLET
2023-05-01 12:40 ` [PATCH 4/5] nvmet: Reorder fields in 'struct nvme_dhchap_queue_context' Christophe JAILLET
2023-05-01 12:40 ` [PATCH 5/5] nvmet: Reorder fields in 'struct nvmefc_fcp_req' Christophe JAILLET
2023-05-01 13:57 ` [PATCH 0/5] optimize some data structure in nvme Sagi Grimberg
2023-05-12 20:26 ` Christoph Hellwig
2023-05-13 1:01 ` Chaitanya Kulkarni
2023-05-15 17:13 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGI/6DT30JBfQPnG@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox