From: Johan Hovold <johan@kernel.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Flush RSC sleep & wake votes
Date: Mon, 15 May 2023 13:52:17 +0200 [thread overview]
Message-ID: <ZGIc8SPNy0oqCqjR@hovoldconsulting.com> (raw)
In-Reply-To: <20230512150425.3171122-1-quic_bjorande@quicinc.com>
On Fri, May 12, 2023 at 08:04:25AM -0700, Bjorn Andersson wrote:
> The rpmh driver will cache sleep and wake votes until the cluster
> power-domain is about to enter idle, to avoid unnecessary writes. So
> associate the apps_rsc with the cluster pd, so that it can be notified
> about this event.
>
> Without this, only AMC votes are being commited.
I'm sure I'm missing some details here, but from reading (and tracing)
the code it looks like the cached votes are still being flushed albeit
via rpmh_rsc_cpu_pm_callback() as the individual CPUs go down.
There wasn't really any obvious motivation in the series adding support
for the cluster domain as to why the new mechanism is preferred (e.g. if
this is an actual fix or just an optimisation done to align with
downstream):
https://lore.kernel.org/all/20221018152837.619426-1-ulf.hansson@linaro.org/
Either way, this appears to work as intended even if it does not in
itself have any significant effect on the X13s power consumption (in
idle or suspend).
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Tested-by: Johan Hovold <johan+linaro@kernel.org>
Johan
prev parent reply other threads:[~2023-05-15 11:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 15:04 [PATCH] arm64: dts: qcom: sc8280xp: Flush RSC sleep & wake votes Bjorn Andersson
2023-05-13 9:09 ` Konrad Dybcio
2023-05-15 2:38 ` Bjorn Andersson
2023-05-15 9:34 ` Konrad Dybcio
2023-05-16 21:01 ` Bjorn Andersson
2023-05-17 21:23 ` Konrad Dybcio
2023-05-15 11:54 ` Johan Hovold
2023-05-15 3:33 ` Bjorn Andersson
2023-05-15 4:36 ` Manivannan Sadhasivam
2023-05-15 11:52 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGIc8SPNy0oqCqjR@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox