Re: [PATCH v1 1/1] scripts/tags.sh: Fix gtags generation for O= kernel builds

Ahmed S. Darwish
2023-05-04T22:00:55Z

Hi Nathan,

On Thu, 04 May 2023, Nathan Chancellor wrote:
>
> On Thu, May 04, 2023 at 10:18:33PM +0200, Ahmed S. Darwish wrote:
...
> > + suffixparams=
> > + if [ -v O ]; then
>
> I think
>
> if [ -n "$O" ]; then
>
> would match the style preferred by Kbuild (though that is usually for
> portability sake, which probably does not matter here since bash is
> explicitly requested). Perhaps not worth addressing if there is no other
> reason for a v2.
>

Thanks, I'll do it. I've just discovered that a v2 is necessary anyway.

If O= has a "~", for example as in:

make O=~/build/ gtags

the snippet below:

> > + suffixparams="-C $tree $O"
> > + fi
> > + all_target_sources | gtags -i -f - $suffixparams
^
will fail since the "~" in the O= directory path won't get dereferenced
before getting passed to the gtags call (an eval is needed).

I'll submit a v2 shortly.

Kind regards,

--
Ahmed S. Darwish
Linutronix GmbH