From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E959C7EE2A for ; Wed, 17 May 2023 00:19:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231481AbjEQATq (ORCPT ); Tue, 16 May 2023 20:19:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbjEQATo (ORCPT ); Tue, 16 May 2023 20:19:44 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E1352118 for ; Tue, 16 May 2023 17:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684282734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fAWA1BLnS6OZoKpUWNVEQYD1QFUo+cJ+dgpIwEFG8vQ=; b=MyKNlXGC4lLrsgqQZYBSCeq2R2EJhlFeyansotgpO/+ZclrpYBkaDI37GGK9doMDSe/1y/ f1pFHuluczWb8GWyBAQuVluCnMXMH0JC8k48ONbygBT39+5XFPjbfnSxAyjBAf4NpEvlWx zFPPjG3G/kE2lNOhp0hVuCZMe/dcU00= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-xSYMGA7rM6C5pLqfMBrTEw-1; Tue, 16 May 2023 20:18:51 -0400 X-MC-Unique: xSYMGA7rM6C5pLqfMBrTEw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B3A533810B05; Wed, 17 May 2023 00:18:50 +0000 (UTC) Received: from localhost (ovpn-12-79.pek2.redhat.com [10.72.12.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 02B2A1410DD5; Wed, 17 May 2023 00:18:49 +0000 (UTC) Date: Wed, 17 May 2023 08:18:46 +0800 From: Baoquan He To: Vinod Koul Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH RESEND 2/2] dmaengine: make QCOM_HIDMA depend on HAS_IOMEM Message-ID: References: <20230506111628.712316-1-bhe@redhat.com> <20230506111628.712316-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/16/23 at 11:26pm, Vinod Koul wrote: > On 06-05-23, 19:16, Baoquan He wrote: > > On s390 systems (aka mainframes), it has classic channel devices for > > networking and permanent storage that are currently even more common > > than PCI devices. Hence it could have a fully functional s390 kernel > > with CONFIG_PCI=n, then the relevant iomem mapping functions > > [including ioremap(), devm_ioremap(), etc.] are not available. > > > > Here let QCOM_HIDMA depend on HAS_IOMEM so that it won't be built to > > cause below compiling error if PCI is unset. > > I have 2/2 patch here, where is patch 1 of 2..? It's here, thanks for check. https://lore.kernel.org/all/20230506111628.712316-2-bhe@redhat.com/T/#u I used get_maintainer to get reivewers list, seems your contact is only put in 2/2 patch. I also sent to lkml, linux-mm and s390 mailing list, so the whole series can be seen in any of the ML. Thanks Baoquan > > > > > -------------------------------------------------------- > > ld: drivers/dma/qcom/hidma.o: in function `hidma_probe': > > hidma.c:(.text+0x4b46): undefined reference to `devm_ioremap_resource' > > ld: hidma.c:(.text+0x4b9e): undefined reference to `devm_ioremap_resource' > > make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Error 1 > > make: *** [Makefile:1264: vmlinux] Error 2 > > > > Signed-off-by: Baoquan He > > Reviewed-by: Niklas Schnelle > > Cc: Andy Gross > > Cc: Bjorn Andersson > > Cc: Konrad Dybcio > > Cc: Vinod Koul > > Cc: linux-arm-msm@vger.kernel.org > > Cc: dmaengine@vger.kernel.org > > --- > > drivers/dma/qcom/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig > > index 3f926a653bd8..ace75d7b835a 100644 > > --- a/drivers/dma/qcom/Kconfig > > +++ b/drivers/dma/qcom/Kconfig > > @@ -45,6 +45,7 @@ config QCOM_HIDMA_MGMT > > > > config QCOM_HIDMA > > tristate "Qualcomm Technologies HIDMA Channel support" > > + depends on HAS_IOMEM > > select DMA_ENGINE > > help > > Enable support for the Qualcomm Technologies HIDMA controller. > > -- > > 2.34.1 > > -- > ~Vinod >