From: Ido Schimmel <idosch@idosch.org>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, dsahern@gmail.com, shuah@kernel.org,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net
Subject: Re: [PATCH] selftests: fib_tests: mute cleanup error message
Date: Wed, 17 May 2023 09:00:37 +0300 [thread overview]
Message-ID: <ZGRthdt5u88zs6xy@shredder> (raw)
In-Reply-To: <20230517041119.202072-1-po-hsu.lin@canonical.com>
On Wed, May 17, 2023 at 12:11:19PM +0800, Po-Hsu Lin wrote:
> In the end of the test, there will be an error message induced by the
> `ip netns del ns1` command in cleanup()
>
> Tests passed: 201
> Tests failed: 0
> Cannot remove namespace file "/run/netns/ns1": No such file or directory
>
> Redirect the error message to /dev/null to mute it.
>
> Fixes: a0e11da78f48 ("fib_tests: Add tests for metrics on routes")
I don't think this tag is correct. More likely that this is caused by
commit b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit").
You can even reproduce it with '-h':
# ./fib_tests.sh -h
usage: fib_tests.sh OPTS
[...]
Cannot remove namespace file "/var/run/netns/ns1": No such file or directory
Reverting the commit I mentioned makes it go away.
Also, please use "PATCH net" prefix:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#tl-dr
next prev parent reply other threads:[~2023-05-17 6:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 4:11 [PATCH] selftests: fib_tests: mute cleanup error message Po-Hsu Lin
2023-05-17 6:00 ` Ido Schimmel [this message]
2023-05-18 3:22 ` Po-Hsu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGRthdt5u88zs6xy@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=po-hsu.lin@canonical.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox