From: Sasha Levin <sashal@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
mchehab@kernel.org, bleung@chromium.org, groeck@chromium.org,
kevin.chiu.17802@gmail.com,
scott_chao@wistron.corp-partner.google.com,
zoey_wu@wistron.corp-partner.google.com,
hellojacky0226@hotmail.com, linux-media@vger.kernel.org,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH AUTOSEL 6.3 34/44] media: cros-ec-cec: Don't exit early in .remove() callback
Date: Thu, 18 May 2023 13:02:35 -0400 [thread overview]
Message-ID: <ZGZaK2lp8NCvyAmk@sashalap> (raw)
In-Reply-To: <20230501152632.ccsvhl2c6ihuizcf@pengutronix.de>
On Mon, May 01, 2023 at 05:26:32PM +0200, Uwe Kleine-König wrote:
>Hello,
>
>On Sun, Apr 30, 2023 at 10:56:22PM -0400, Sasha Levin wrote:
>> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> [ Upstream commit 0ff7aee24e47beb4306ce050824b54147f2fabfa ]
>>
>> Exiting early in remove without releasing all acquired resources yields
>> leaks. Note that e.g. memory allocated with devm_zalloc() is freed after
>> .remove() returns, even if the return code was negative.
>>
>> While blocking_notifier_chain_unregister() won't fail and so the
>> change is somewhat cosmetic, platform driver's .remove callbacks are
>> about to be converted to return void. To prepare that, keep the error
>> message but don't return early.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>While I'm positive this change doesn't break anything, it also doesn't
>fix anything and is only cosmetic (+ preparing a later change).
>
>Unless you need it as a dependency I'd say, don't backport it for
>stable.
Ack, dropped. Thanks!
--
Thanks,
Sasha
next prev parent reply other threads:[~2023-05-18 17:02 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 2:55 [PATCH AUTOSEL 6.3 01/44] drm/displayid: add displayid_get_header() and check bounds better Sasha Levin
2023-05-01 2:55 ` [PATCH AUTOSEL 6.3 02/44] drm/amd/display: populate subvp cmd info only for the top pipe Sasha Levin
2023-05-01 2:55 ` [PATCH AUTOSEL 6.3 03/44] drm/amd/display: Correct DML calculation to align HW formula Sasha Levin
2023-05-01 2:55 ` [PATCH AUTOSEL 6.3 04/44] drm/amd/display: enable DPG when disabling plane for phantom pipe Sasha Levin
2023-05-01 2:55 ` [PATCH AUTOSEL 6.3 05/44] platform/x86: x86-android-tablets: Add Acer Iconia One 7 B1-750 data Sasha Levin
2023-05-01 2:55 ` [PATCH AUTOSEL 6.3 06/44] drm/amd/display: Enable HostVM based on rIOMMU active Sasha Levin
2023-05-01 2:55 ` [PATCH AUTOSEL 6.3 07/44] drm/amd/display: Use DC_LOG_DC in the trasform pixel function Sasha Levin
2023-05-01 2:55 ` [PATCH AUTOSEL 6.3 08/44] regmap: cache: Return error in cache sync operations for REGCACHE_NONE Sasha Levin
2023-05-01 2:55 ` [PATCH AUTOSEL 6.3 09/44] remoteproc: imx_dsp_rproc: Add custom memory copy implementation for i.MX DSP Cores Sasha Levin
2023-05-01 2:55 ` [PATCH AUTOSEL 6.3 10/44] arm64: dts: qcom: msm8996: Add missing DWC3 quirks Sasha Levin
2023-05-01 2:55 ` [PATCH AUTOSEL 6.3 11/44] accel/habanalabs: postpone mem_mgr IDR destruction to hpriv_release() Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 12/44] drm/amd/display: reallocate DET for dual displays with high pixel rate ratio Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 13/44] media: imx-jpeg: Bounds check sizeimage access Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 14/44] media: cx23885: Fix a null-ptr-deref bug in buffer_prepare() and buffer_finish() Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 15/44] media: pci: tw68: Fix null-ptr-deref bug in buf prepare and finish Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 16/44] media: pvrusb2: VIDEO_PVRUSB2 depends on DVB_CORE to use dvb_* symbols Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 17/44] platform/x86/intel: vsec: Explicitly enable capabilities Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 18/44] ACPI: processor: Check for null return of devm_kzalloc() in fch_misc_setup() Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 19/44] drm/rockchip: dw_hdmi: cleanup drm encoder during unbind Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 20/44] memstick: r592: Fix UAF bug in r592_remove due to race condition Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 21/44] arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0 Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 22/44] firmware: arm_sdei: Fix sleep from invalid context BUG Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 23/44] ACPI: EC: Fix oops when removing custom query handlers Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 24/44] drm/amd/display: fixed dcn30+ underflow issue Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 25/44] remoteproc: stm32_rproc: Add mutex protection for workqueue Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 26/44] accel/ivpu: Remove D3hot delay for Meteorlake Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 27/44] drm/tegra: Avoid potential 32-bit integer overflow Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 28/44] drm/msm/dp: Clean up handling of DP AUX interrupts Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 29/44] ACPICA: Avoid undefined behavior: applying zero offset to null pointer Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 30/44] ACPICA: ACPICA: check null return of ACPI_ALLOCATE_ZEROED in acpi_db_display_objects Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 31/44] arm64: dts: qcom: sdm845-polaris: Drop inexistent properties Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 32/44] arm64: dts: qcom: sm6115-j606f: Add ramoops node Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 33/44] irqchip/gicv3: Workaround for NVIDIA erratum T241-FABRIC-4 Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 34/44] media: cros-ec-cec: Don't exit early in .remove() callback Sasha Levin
2023-05-01 15:26 ` Uwe Kleine-König
2023-05-18 17:02 ` Sasha Levin [this message]
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 35/44] media: ipu3-cio2: support multiple sensors and VCMs with same HID Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 36/44] ACPI: video: Remove desktops without backlight DMI quirks Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 37/44] drm/amd/display: Correct DML calculation to follow HW SPEC Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 38/44] drm/amd: Fix an out of bounds error in BIOS parser Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 39/44] drm/amdgpu: Fix sdma v4 sw fini error Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 40/44] media: Prefer designated initializers over memset for subdev pad ops Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 41/44] drm/amdgpu: Enable IH retry CAM on GFX9 Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 42/44] media: mediatek: vcodec: Fix potential array out-of-bounds in decoder queue_setup Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 43/44] platform/x86/amd: pmc: Fix memory leak in amd_pmc_stb_debugfs_open_v2() Sasha Levin
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 44/44] hwmon: (nzxt-smart2) add another USB ID Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGZaK2lp8NCvyAmk@sashalap \
--to=sashal@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=hellojacky0226@hotmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kevin.chiu.17802@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=scott_chao@wistron.corp-partner.google.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zoey_wu@wistron.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox