From: Simon Horman <simon.horman@corigine.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Martin Wetterwald <martin@wetterwald.eu>,
Arnd Bergmann <arnd@arndb.de>, XueBing Chen <chenxuebing@jari.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Saravana Kannan <saravanak@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net-next] net: ipconfig: move ic_nameservers_fallback into #ifdef block
Date: Fri, 19 May 2023 15:06:40 +0200 [thread overview]
Message-ID: <ZGd0YMg1y5wx4bRX@corigine.com> (raw)
In-Reply-To: <20230519093250.4011881-1-arnd@kernel.org>
On Fri, May 19, 2023 at 11:32:38AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new variable is only used when IPCONFIG_BOOTP is defined and otherwise
> causes a warning:
>
> net/ipv4/ipconfig.c:177:12: error: 'ic_nameservers_fallback' defined but not used [-Werror=unused-variable]
>
> Move it next to the user.
>
> Fixes: 81ac2722fa19 ("net: ipconfig: Allow DNS to be overwritten by DHCPACK")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks Arnd,
I was able to observe this too.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-05-19 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 9:32 [PATCH] [net-next] net: ipconfig: move ic_nameservers_fallback into #ifdef block Arnd Bergmann
2023-05-19 13:06 ` Simon Horman [this message]
2023-05-22 10:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGd0YMg1y5wx4bRX@corigine.com \
--to=simon.horman@corigine.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chenxuebing@jari.cn \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@wetterwald.eu \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox