From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840A4C7EE29 for ; Fri, 19 May 2023 17:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232064AbjESRgL (ORCPT ); Fri, 19 May 2023 13:36:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231448AbjESRgI (ORCPT ); Fri, 19 May 2023 13:36:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 615F6BC; Fri, 19 May 2023 10:36:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C873765A03; Fri, 19 May 2023 17:36:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53E23C433D2; Fri, 19 May 2023 17:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684517765; bh=fTmCX95uDO4JmgzC6JzK4SCPqiqeBArOtaaIcRc+kAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jz0boiMefZuw5q2eYukuYNt69NAWp8uDGYhmif6qa4V/1GEozEpWO2z17Vnfh1VOh 2weE1zscBWBvZBeagyFDE1UgwxROY7qXrR11gD95jgzmEL08d9NFpgdGhYGHF5he42 OqZb+GmmMG7mTUZYIPR8scbjCkQ6D4fAWwd55JZp/jqlx4cROusJU5+dXZF7a6dyL0 bjVKxJt07hdrzE4Zdko9AekpgXQhHjhR7XgDEjNaxYQFDKapbxYTehLmxpe2vqieg8 8ERfNmu3j9zT6PNmF5VcPgcb/ROgPb/1N97xkqWZvSoW+6JQdI4xPvPA7lvCKk4PGc 472UbKYuL/rvA== Date: Fri, 19 May 2023 23:06:00 +0530 From: Vinod Koul To: Cai Huoqing Cc: Serge Semin , Gustavo Pimentel , Jingoo Han , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v10 0/4] dmaengine: dw-edma: Add support for native HDMA Message-ID: References: <20230517030115.21093-1-cai.huoqing@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19-05-23, 21:39, Cai Huoqing wrote: > On 19 5月 23 16:57:06, Vinod Koul wrote: > > On 17-05-23, 11:01, Cai Huoqing wrote: > > > Add support for HDMA NATIVE, as long the IP design has set > > > the compatible register map parameter-HDMA_NATIVE, > > > which allows compatibility for native HDMA register configuration. > > > > > > The HDMA Hyper-DMA IP is an enhancement of the eDMA embedded-DMA IP. > > > And the native HDMA registers are different from eDMA, > > > so this patch add support for HDMA NATIVE mode. > > > > > > HDMA write and read channels operate independently to maximize > > > the performance of the HDMA read and write data transfer over > > > the link When you configure the HDMA with multiple read channels, > > > then it uses a round robin (RR) arbitration scheme to select > > > the next read channel to be serviced.The same applies when > > > youhave multiple write channels. > > > > > > The native HDMA driver also supports a maximum of 16 independent > > > channels (8 write + 8 read), which can run simultaneously. > > > Both SAR (Source Address Register) and DAR (Destination Address Register) > > > are aligned to byte. > > > > > > Cai Huoqing (1): > > > dmaengine: dw-edma: Add support for native HDMA > > > > > > Cai huoqing (3): > > > dmaengine: dw-edma: Rename dw_edma_core_ops structure to > > > dw_edma_plat_ops > > > dmaengine: dw-edma: Create a new dw_edma_core_ops structure to > > > abstract controller operation > > > dmaengine: dw-edma: Add HDMA DebugFS support > > > > You should have a single name for all these patches :-( > > Hi Vinod, > > Thanks for your reply. > > Do you mean patch[0/4] and patch[3/4] shouldn't have the same name? It should be Cai Huoqing or Cai huoqing not both :-) > > Thanks, > Cai- > > > > > > > > Tested-by: Serge Semin > > > > > > v9->v10: > > > 1.Update commit log. > > > 2.rebase for dma-next > > > > > > v9 link: > > > https://lore.kernel.org/lkml/20230413033156.93751-1-cai.huoqing@linux.dev/ > > > > > > drivers/dma/dw-edma/Makefile | 8 +- > > > drivers/dma/dw-edma/dw-edma-core.c | 86 ++---- > > > drivers/dma/dw-edma/dw-edma-core.h | 58 ++++ > > > drivers/dma/dw-edma/dw-edma-pcie.c | 4 +- > > > drivers/dma/dw-edma/dw-edma-v0-core.c | 85 +++++- > > > drivers/dma/dw-edma/dw-edma-v0-core.h | 14 +- > > > drivers/dma/dw-edma/dw-hdma-v0-core.c | 296 +++++++++++++++++++ > > > drivers/dma/dw-edma/dw-hdma-v0-core.h | 17 ++ > > > drivers/dma/dw-edma/dw-hdma-v0-debugfs.c | 170 +++++++++++ > > > drivers/dma/dw-edma/dw-hdma-v0-debugfs.h | 22 ++ > > > drivers/dma/dw-edma/dw-hdma-v0-regs.h | 129 ++++++++ > > > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > > > include/linux/dma/edma.h | 7 +- > > > 13 files changed, 807 insertions(+), 91 deletions(-) > > > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.c > > > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.h > > > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.c > > > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.h > > > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-regs.h > > > > > > -- > > > 2.34.1 > > > > -- > > ~Vinod -- ~Vinod