From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CFFFC7EE23 for ; Mon, 22 May 2023 16:10:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233777AbjEVQK5 (ORCPT ); Mon, 22 May 2023 12:10:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbjEVQKw (ORCPT ); Mon, 22 May 2023 12:10:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E95BB6; Mon, 22 May 2023 09:10:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B780561D14; Mon, 22 May 2023 16:10:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3F5FC433D2; Mon, 22 May 2023 16:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684771850; bh=dl5gBDvuGabe6NnEiM5v+6b9yh126Z8E64wCTQABV84=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=MswPmM9NI3e5xAQ63TPGAmz4LWfmAxvmOAm1w6Nxd5caDVbDY6EJ5DO4JdAZZfyMw xX0IU8l5sn6Ptp0juO72gtGBhjWuou9urMmu6svigxrG3lxrr6JJBF5/aZILGlfJh3 yuixiOI3kgB4WHVugbEt3UB6rBwWzWf2Ze0dprMUm6e/BpCrNJ+69Op93e+mfyboEg vfgmEZRTOlLHgPs4uQZwhBV5l2POLB4dhKt/IeKgUisBKPCZDn9cp3KW7CHnLDegNK MZyA85wQzQzmERMxYY4VGiZDG1pvVuNws7FOj8zy0ix1S62956R4kr/THBNpYb28Ze qiCDSKXDh3gpQ== Date: Mon, 22 May 2023 11:10:48 -0500 From: Bjorn Helgaas To: =?utf-8?B?5pu+56Wl57+8?= Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Kishon Vijay Abraham I , hust-os-kernel-patches@googlegroups.com, Dongliang Mu , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: dwc: keystone: Free IRQ in `ks_pcie_remove` and the error handling section of `ks_pcie_probe` Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <36474dbb-5020-9044-b47c-cb377fa5dea7@stu.xidian.edu.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2023 at 02:07:10PM +0800, 曾祥翼 wrote: > On 17/5/2023 03:49, Bjorn Helgaas wrote: > > On Tue, May 16, 2023 at 01:16:59PM +0800, Xiangyi Zeng wrote: > > ... > > > Fixes: 0790eb175ee0 ("PCI: keystone: Cleanup error_irq configuration") > > > Signed-off-by: Xiangyi Zeng > > > Reviewed-by: Dongliang Mu > > > > It's best if the Reviewed-by tag is not added until Dongliang sends > > email with that tag directly to the mailing list. Internal reviews > > before posting to the mailing list aren't worth much. > > In our internal review process, only the patch with the Reviewed-by > tag can be submitted to the mailing list. You can check this in our > google group. > https://groups.google.com/g/hust-os-kernel-patches/c/bt397rzVL24/m/l52XYbG4AgAJ > We will consider omitting this tag when sending to the kernel mailing > list in the future. It's great that Dongliang has already reviewed it; I'm not suggesting you omit any of that internal review. My point is that it's best if Dongliang's email review appears on linux-pci in addition to whatever internal email list you use. The hust-os-kernel-patches Google Group is not archived and searchable the same way linux-pci@vger.kernel.org is on https://lore.kernel.org/linux-pci/. Bjorn