public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Breathitt Gray <william.gray@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/3] gpio: 104-dio-48e: Add Counter/Timer support
Date: Mon, 22 May 2023 12:44:32 -0400	[thread overview]
Message-ID: <ZGub8Gyu773b+V92@fedora> (raw)
In-Reply-To: <CACRpkdYdcU1JNmk7Jyyw+MA+GBKG950P1Nbn7QB4Nx7YJ1jwig@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

On Sat, May 20, 2023 at 09:28:15PM +0200, Linus Walleij wrote:
> On Sun, Apr 16, 2023 at 7:37 PM William Breathitt Gray
> <william.gray@linaro.org> wrote:
> 
> > The 104-DIO-48E features an 8254 Counter/Timer chip providing three
> > counter/timers which can be used for frequency measurement, frequency
> > output, pulse width modulation, pulse width measurement, event count,
> > etc. The counter/timers use the same addresses as PPI 0 (addresses 0x0
> > to 0x3), so a raw_spinlock_t is used to synchronize operations between
> > the two regmap mappings to prevent clobbering.
> >
> > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> 
> Very interesting development here.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Yours,
> Linus Walleij

With this patch, we should now have complete support for every feature
available on this device. A nice milestone as well after first
introducing basic GPIO support for the ACCES 104-DIO-48E in 2016.

Given that there is also Intel 8255 support, it would be fun to route
back one of the device's GPIO outputs into the Intel 8254 timer gate and
hook up a simple speaker; we could get some nice beep generation going
and party like it's 1989! B-)

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-05-22 16:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-16 17:36 [PATCH 0/3] Add Intel 8254 Counter support William Breathitt Gray
2023-04-16 17:36 ` [PATCH 1/3] counter: i8254: Introduce the Intel 8254 interface library module William Breathitt Gray
2023-06-08 14:43   ` William Breathitt Gray
2023-06-20 14:03     ` Jarkko Nikula
2023-06-12  5:14       ` William Breathitt Gray
2023-04-16 17:36 ` [PATCH 2/3] gpio: 104-dio-48e: Add Counter/Timer support William Breathitt Gray
2023-05-17 14:35   ` Bartosz Golaszewski
2023-05-20 19:28   ` Linus Walleij
2023-05-22 16:44     ` William Breathitt Gray [this message]
2023-04-16 17:36 ` [PATCH 3/3] iio: addac: stx104: Add 8254 " William Breathitt Gray
2023-05-20  9:53 ` [PATCH 0/3] Add Intel 8254 Counter support andy.shevchenko
2023-05-22 16:20   ` William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGub8Gyu773b+V92@fedora \
    --to=william.gray@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox