Re: [PATCH net-next v4 2/4] net: ethernet: altera-tse: Convert to mdio-regmap and use PCS Lynx

Maxime Chevallier
2023-06-05T13:15:26Z

Hi,

On Thu, 1 Jun 2023 16:14:52 +0200
Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:

> The newly introduced regmap-based MDIO driver allows for an easy mapping
> of an mdiodevice onto the memory-mapped TSE PCS, which is actually a
> Lynx PCS.
>
> Convert Altera TSE to use this PCS instead of the pcs-altera-tse, which
> is nothing more than a memory-mapped Lynx PCS.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
[ ... ]

> - ret = request_and_map(pdev, "pcs", &pcs_res,
> - &priv->pcs_base);
> + ret = request_and_map(pdev, "pcs", &pcs_res, &priv->pcs_base);

It turns out I'm missing the zeroing of pcs_regmap_cfg, which can trigger
errors at probe time. I know this series has been applied, and that I can
send a followup fix, but due to the missing regmap patch in the net-next
tree, this series will break altera_tse and dwmac_socfpga anyway,as
mentionned here (and in the cover):

https://lore.kernel.org/netdev/20230605142039.3f8d1530@pc-7.home/

Is reverting the way to go then ?

Best regards,

Maxime