From: Johan Hovold <johan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com,
ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com,
linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: codecs: wsa883x: do not set can_multi_write flag
Date: Mon, 5 Jun 2023 10:08:34 +0200 [thread overview]
Message-ID: <ZH2YAmBY-GNKABSB@hovoldconsulting.com> (raw)
In-Reply-To: <168492769030.49784.4719862081052299023.b4-ty@kernel.org>
On Wed, May 24, 2023 at 12:28:10PM +0100, Mark Brown wrote:
> On Tue, 23 May 2023 16:46:04 +0100, Srinivas Kandagatla wrote:
> > regmap-sdw does not support multi register writes, so there is
> > no point in setting this flag. This also leads to incorrect
> > programming of WSA codecs with regmap_multi_reg_write() call.
> >
> > This invalid configuration should have been rejected by regmap-sdw.
> >
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
>
> Thanks!
>
> [1/2] ASoC: codecs: wsa883x: do not set can_multi_write flag
> commit: 40ba0411074485e2cf1bf8ee0f3db27bdff88394
> [2/2] ASoC: codecs: wsa881x: do not set can_multi_write flag
> commit: 6e7a6d4797ef521c0762914610ed682e102b9d36
These were merged for 6.5 but the corresponding sanity check for regmap
has now been included in 6.4-rc5 which consequently breaks these codecs
(similar for wcd938x-sdw):
[ 11.443485] wsa883x-codec sdw:0:0217:0202:00:1: error -ENOTSUPP: regmap_init failed
[ 11.443525] wsa883x-codec sdw:0:0217:0202:00:1: Probe of wsa883x-codec failed: -524
[ 11.443554] wsa883x-codec: probe of sdw:0:0217:0202:00:1 failed with error -52
Is it possible to get also these fixes into 6.4 final?
Johan
next prev parent reply other threads:[~2023-06-05 8:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 15:46 [PATCH 1/2] ASoC: codecs: wsa883x: do not set can_multi_write flag Srinivas Kandagatla
2023-05-23 15:46 ` [PATCH 2/2] ASoC: codecs: wsa881x: " Srinivas Kandagatla
2023-05-23 16:55 ` [PATCH 1/2] ASoC: codecs: wsa883x: " Mark Brown
2023-05-24 8:51 ` Srinivas Kandagatla
2023-05-24 8:57 ` Mark Brown
2023-05-24 9:42 ` Srinivas Kandagatla
2023-05-24 9:48 ` Mark Brown
2023-05-24 10:09 ` Srinivas Kandagatla
2023-05-24 10:14 ` Mark Brown
2023-05-24 11:28 ` Mark Brown
2023-06-05 8:08 ` Johan Hovold [this message]
2023-06-05 12:24 ` Mark Brown
2023-06-05 12:31 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH2YAmBY-GNKABSB@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox