Re: [PATCH v2 06/11] KVM: arm64: hide MOPS from guests

Oliver Upton
2023-06-05T15:46:36Z

On Sat, Jun 03, 2023 at 09:42:18AM +0100, Marc Zyngier wrote:
> On Tue, 09 May 2023 15:22:30 +0100,
> Kristina Martsenko <kristina.martsenko@arm.com> wrote:
> >
> > As FEAT_MOPS is not supported in guests yet, hide it from the ID
> > registers for guests.
> >
> > The MOPS instructions are UNDEFINED in guests as HCRX_EL2.MSCEn is not
> > set in HCRX_GUEST_FLAGS, and will take an exception to EL1 if executed.
> >
> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> > Signed-off-by: Kristina Martsenko <kristina.martsenko@arm.com>
>
> This is very likely to clash with Jing's series that completely
> reworks the whole idreg series, but as long as this is on its own
> branch, we can deal with that.

Yup, we will definitely want to get that ironed out. I'll pull Catalin's
branch when this all gets queued up.

Acked-by: Oliver Upton <oliver.upton@linux.dev>

--
Thanks,
Oliver