From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E57C7EE23 for ; Mon, 5 Jun 2023 22:16:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233086AbjFEWQe (ORCPT ); Mon, 5 Jun 2023 18:16:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231764AbjFEWQ1 (ORCPT ); Mon, 5 Jun 2023 18:16:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4717510B for ; Mon, 5 Jun 2023 15:16:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD06562B4C for ; Mon, 5 Jun 2023 22:16:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2F86C433EF; Mon, 5 Jun 2023 22:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686003383; bh=WVGdFDvKNz9o0nDSSbiXtPP3pwqKvj5fwhy7WCAwqsk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EuIxGYJwXI3jO5VWQZminZPOdmYJmtywgAGDVctJnc9rwDAMtZPjtHnlsuAtZoA3R PtNOUYurq4Z+C0wbcfw30lchccWv9CL/1sBsOek7BDPjxXK83vOHs4URK2iR3Exifk m8kv2VgpT4eZnBKu+Ij2k4bv6cHklOa7fEqURCLgszBBr1BtSlxxEm5SbYxEtOOZjl xMctHR3t7qagKfDzRa1TRWjQUHBt21HqE3lCTPqbql1+ycLXPl4tiKB1L5TkCdRqtW P6jKacFg8kecBXmF/Vb0U44TZa9+872KXkxZi5HClJV3p3b6OW84lC71N1j8EA56LF JbNdreTB9F2sw== Date: Tue, 6 Jun 2023 00:16:20 +0200 From: Frederic Weisbecker To: Anna-Maria Behnsen Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Tejun Heo , Lai Jiangshan Subject: Re: [PATCH v6 08/21] workqueue: Use global variant for add_timer() Message-ID: References: <20230510072817.116056-1-anna-maria@linutronix.de> <20230510072817.116056-9-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230510072817.116056-9-anna-maria@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Wed, May 10, 2023 at 09:28:04AM +0200, Anna-Maria Behnsen a écrit : > The implementation of the NOHZ pull at expiry model will change the timer > bases per CPU. Timers, that have to expire on a specific CPU, require the > TIMER_PINNED flag. If the CPU doesn't matter, the TIMER_PINNED flag must be > dropped. This is required for call sites which use the timer alternately as > pinned and not pinned timer like workqueues do. > > Therefore use add_timer_global() to make sure TIMER_PINNED flag is dropped. > > Signed-off-by: Anna-Maria Behnsen > Cc: Tejun Heo > Cc: Lai Jiangshan Reviewed-by: Frederic Weisbecker