From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09C3EC77B73 for ; Mon, 5 Jun 2023 22:25:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231302AbjFEWZk (ORCPT ); Mon, 5 Jun 2023 18:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbjFEWZi (ORCPT ); Mon, 5 Jun 2023 18:25:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7BBBF4 for ; Mon, 5 Jun 2023 15:25:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C1F4622BD for ; Mon, 5 Jun 2023 22:25:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21917C433D2; Mon, 5 Jun 2023 22:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686003936; bh=s8/kkstSBxgPDYSY23EyfYDmhW5ZHJc98RUffgqvWog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hXT5vZubjHO/n6kjop3dK/E1x8VHvvRzOMJRiGeQqtP790zofD2Iby2VD6ORIIi1U TbFBSc5YqdcYQcy/CfD3KKtHyZQ7A+FOGc3cXWz5PWelFExdNrp9vCPw/FgHAcFGRr ia9X1lGuu9w/voozatrDC55s8zR3WOFbxx0wd/U91sYEKOE1feEq3qaHu2YR5Tzx0S QRZuKxhDbA2zHi7OZ1PXt+VlxrYpJhHfPKokScmMnOZoRWILBhv6HEPi2OSYOpzZ/t 9k8fSiMLQqloWzZbTrwRM5c+rNRKL7k5RTNYyewVJcnzEwlQmWh08hCPp7Ap0/nPw7 4qFNDcGYEHIFQ== Date: Tue, 6 Jun 2023 00:25:33 +0200 From: Frederic Weisbecker To: Anna-Maria Behnsen Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Tejun Heo , Lai Jiangshan Subject: Re: [PATCH v7 08/21] workqueue: Use global variant for add_timer() Message-ID: References: <20230524070629.6377-1-anna-maria@linutronix.de> <20230524070629.6377-9-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230524070629.6377-9-anna-maria@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Wed, May 24, 2023 at 09:06:16AM +0200, Anna-Maria Behnsen a écrit : > The implementation of the NOHZ pull at expiry model will change the timer > bases per CPU. Timers, that have to expire on a specific CPU, require the > TIMER_PINNED flag. If the CPU doesn't matter, the TIMER_PINNED flag must be > dropped. This is required for call sites which use the timer alternately as > pinned and not pinned timer like workqueues do. > > Therefore use add_timer_global() to make sure TIMER_PINNED flag is dropped. > > Signed-off-by: Anna-Maria Behnsen > Acked-by: Tejun Heo > Cc: Tejun Heo > Cc: Lai Jiangshan Getting confused between v6 and v7... Anyway: Reviewed-by: Frederic Weisbecker