* Re: [PATCH] memcg: use helper macro FLUSH_TIME
2023-06-03 7:21 [PATCH] memcg: use helper macro FLUSH_TIME Miaohe Lin
@ 2023-06-03 7:36 ` Shakeel Butt
2023-06-03 11:13 ` Muchun Song
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Shakeel Butt @ 2023-06-03 7:36 UTC (permalink / raw)
To: Miaohe Lin
Cc: hannes, mhocko, roman.gushchin, akpm, muchun.song, cgroups,
linux-mm, linux-kernel
On Sat, Jun 3, 2023 at 12:21 AM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Shakeel Butt <shakeelb@google.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] memcg: use helper macro FLUSH_TIME
2023-06-03 7:21 [PATCH] memcg: use helper macro FLUSH_TIME Miaohe Lin
2023-06-03 7:36 ` Shakeel Butt
@ 2023-06-03 11:13 ` Muchun Song
2023-06-05 11:32 ` David Hildenbrand
2023-06-06 0:38 ` Roman Gushchin
3 siblings, 0 replies; 5+ messages in thread
From: Muchun Song @ 2023-06-03 11:13 UTC (permalink / raw)
To: Miaohe Lin
Cc: Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt,
Andrew Morton, cgroups, Linux Memory Management List,
linux-kernel
> On Jun 3, 2023, at 15:21, Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] memcg: use helper macro FLUSH_TIME
2023-06-03 7:21 [PATCH] memcg: use helper macro FLUSH_TIME Miaohe Lin
2023-06-03 7:36 ` Shakeel Butt
2023-06-03 11:13 ` Muchun Song
@ 2023-06-05 11:32 ` David Hildenbrand
2023-06-06 0:38 ` Roman Gushchin
3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2023-06-05 11:32 UTC (permalink / raw)
To: Miaohe Lin, hannes, mhocko, roman.gushchin, shakeelb, akpm
Cc: muchun.song, cgroups, linux-mm, linux-kernel
On 03.06.23 09:21, Miaohe Lin wrote:
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index d8569594239c..f204c9f2e69c 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -5397,7 +5397,7 @@ static int mem_cgroup_css_online(struct cgroup_subsys_state *css)
>
> if (unlikely(mem_cgroup_is_root(memcg)))
> queue_delayed_work(system_unbound_wq, &stats_flush_dwork,
> - 2UL*HZ);
> + FLUSH_TIME);
> lru_gen_online_memcg(memcg);
> return 0;
> offline_kmem:
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] memcg: use helper macro FLUSH_TIME
2023-06-03 7:21 [PATCH] memcg: use helper macro FLUSH_TIME Miaohe Lin
` (2 preceding siblings ...)
2023-06-05 11:32 ` David Hildenbrand
@ 2023-06-06 0:38 ` Roman Gushchin
3 siblings, 0 replies; 5+ messages in thread
From: Roman Gushchin @ 2023-06-06 0:38 UTC (permalink / raw)
To: Miaohe Lin
Cc: hannes, mhocko, shakeelb, akpm, muchun.song, cgroups, linux-mm,
linux-kernel
On Sat, Jun 03, 2023 at 03:21:16PM +0800, Miaohe Lin wrote:
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread