From: andy.shevchenko@gmail.com
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: andy.shevchenko@gmail.com, oe-kbuild-all@lists.linux.dev,
linus.walleij@linaro.org, brgl@bgdev.pl, palmer@dabbelt.com,
paul.walmsley@sifive.com, linux-gpio@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] gpio: ath79: Add missing check for platform_get_irq
Date: Tue, 6 Jun 2023 12:28:17 +0300 [thread overview]
Message-ID: <ZH78McKA5nKU1Wg8@surfacebook> (raw)
In-Reply-To: <20230606031841.38665-1-jiasheng@iscas.ac.cn>
Tue, Jun 06, 2023 at 11:18:41AM +0800, Jiasheng Jiang kirjoitti:
Is this v4?
> Add the missing check for platform_get_irq() and return error
> if it fails.
> The returned error code will be dealed with in
> module_platform_driver(ath79_gpio_driver) and the driver will not
> be registered.
No, this functional change and has not to be for the fixes unless _this_ is the
regression you are fixing. Did the driver work before at some point as after
this change?
Otherwise you have to _justify_ that this functional change won't break
existing setups (with broked IRQ in Device Tree, for example).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-06 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 3:18 [PATCH v3] gpio: ath79: Add missing check for platform_get_irq Jiasheng Jiang
2023-06-06 9:28 ` andy.shevchenko [this message]
2023-06-06 9:46 ` andy.shevchenko
-- strict thread matches above, loose matches on Subject: below --
2023-06-07 7:08 Jiasheng Jiang
2023-06-07 14:49 ` andy.shevchenko
2023-06-05 1:53 Jiasheng Jiang
2023-06-05 9:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH78McKA5nKU1Wg8@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=jiasheng@iscas.ac.cn \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox