From: Nicolas Schier <n.schier@avm.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/kallsyms: constify long_options
Date: Tue, 6 Jun 2023 09:32:48 +0200 [thread overview]
Message-ID: <ZH7hIDQcp8pDSpwJ@buildd.core.avm.de> (raw)
In-Reply-To: <20230605120400.1775196-1-masahiroy@kernel.org>
On Mon, Jun 05, 2023 at 09:04:00PM +0900, Masahiro Yamada wrote:
> getopt_long() does not modify this.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Reviewed-by: Nicolas Schier <n.schier@avm.de>
>
> scripts/kallsyms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 0d2db41177b2..8e97ac7b38a6 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -806,7 +806,7 @@ static void record_relative_base(void)
> int main(int argc, char **argv)
> {
> while (1) {
> - static struct option long_options[] = {
> + static const struct option long_options[] = {
> {"all-symbols", no_argument, &all_symbols, 1},
> {"absolute-percpu", no_argument, &absolute_percpu, 1},
> {"base-relative", no_argument, &base_relative, 1},
> --
> 2.39.2
>
prev parent reply other threads:[~2023-06-06 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 12:04 [PATCH] scripts/kallsyms: constify long_options Masahiro Yamada
2023-06-06 7:32 ` Nicolas Schier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH7hIDQcp8pDSpwJ@buildd.core.avm.de \
--to=n.schier@avm.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox