public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] scripts/kallsyms: constify long_options
@ 2023-06-05 12:04 Masahiro Yamada
  2023-06-06  7:32 ` Nicolas Schier
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2023-06-05 12:04 UTC (permalink / raw)
  To: linux-kbuild; +Cc: linux-kernel, Masahiro Yamada

getopt_long() does not modify this.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/kallsyms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 0d2db41177b2..8e97ac7b38a6 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -806,7 +806,7 @@ static void record_relative_base(void)
 int main(int argc, char **argv)
 {
 	while (1) {
-		static struct option long_options[] = {
+		static const struct option long_options[] = {
 			{"all-symbols",     no_argument, &all_symbols,     1},
 			{"absolute-percpu", no_argument, &absolute_percpu, 1},
 			{"base-relative",   no_argument, &base_relative,   1},
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] scripts/kallsyms: constify long_options
  2023-06-05 12:04 [PATCH] scripts/kallsyms: constify long_options Masahiro Yamada
@ 2023-06-06  7:32 ` Nicolas Schier
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Schier @ 2023-06-06  7:32 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: linux-kbuild, linux-kernel

On Mon, Jun 05, 2023 at 09:04:00PM +0900, Masahiro Yamada wrote:
> getopt_long() does not modify this.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---

Reviewed-by: Nicolas Schier <n.schier@avm.de>

> 
>  scripts/kallsyms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 0d2db41177b2..8e97ac7b38a6 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -806,7 +806,7 @@ static void record_relative_base(void)
>  int main(int argc, char **argv)
>  {
>  	while (1) {
> -		static struct option long_options[] = {
> +		static const struct option long_options[] = {
>  			{"all-symbols",     no_argument, &all_symbols,     1},
>  			{"absolute-percpu", no_argument, &absolute_percpu, 1},
>  			{"base-relative",   no_argument, &base_relative,   1},
> -- 
> 2.39.2
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-06  7:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-05 12:04 [PATCH] scripts/kallsyms: constify long_options Masahiro Yamada
2023-06-06  7:32 ` Nicolas Schier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox