* [PATCH] crypto: crct10dif_common Add SPDX-License-Identifier tag @ 2023-06-06 11:03 Franziska Naepelt 2023-06-06 12:33 ` Bagas Sanjaya 0 siblings, 1 reply; 6+ messages in thread From: Franziska Naepelt @ 2023-06-06 11:03 UTC (permalink / raw) To: linux-crypto; +Cc: herbert, davem, linux-kernel, Franziska Naepelt Fix the following checkpatch warning: - WARNING: Missing or malformed SPDX-License-Identifier tag Signed-off-by: Franziska Naepelt <franziska.naepelt@gmail.com> --- crypto/crct10dif_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/crct10dif_common.c b/crypto/crct10dif_common.c index b2fab366f518..134553bf0d60 100644 --- a/crypto/crct10dif_common.c +++ b/crypto/crct10dif_common.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * Cryptographic API. * base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7 -- 2.39.2 (Apple Git-143) ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: crct10dif_common Add SPDX-License-Identifier tag 2023-06-06 11:03 [PATCH] crypto: crct10dif_common Add SPDX-License-Identifier tag Franziska Naepelt @ 2023-06-06 12:33 ` Bagas Sanjaya 2023-06-06 18:07 ` [PATCH v2] " Franziska Naepelt 0 siblings, 1 reply; 6+ messages in thread From: Bagas Sanjaya @ 2023-06-06 12:33 UTC (permalink / raw) To: Franziska Naepelt, linux-crypto Cc: herbert, davem, linux-kernel, Franziska Naepelt, Martin K. Petersen, Tim Chen [-- Attachment #1: Type: text/plain, Size: 328 bytes --] On Tue, Jun 06, 2023 at 01:03:22PM +0200, Franziska Naepelt wrote: > +// SPDX-License-Identifier: GPL-2.0-or-later > /* > * Cryptographic API. > * Shouldn't the license boilerplate text be also removed (and thus completing SPDX conversion)? Thanks. -- An old man doll... just what I always wanted! - Clara [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] crypto: crct10dif_common Add SPDX-License-Identifier tag 2023-06-06 12:33 ` Bagas Sanjaya @ 2023-06-06 18:07 ` Franziska Naepelt 2023-06-07 3:50 ` Bagas Sanjaya 2023-06-16 12:17 ` Herbert Xu 0 siblings, 2 replies; 6+ messages in thread From: Franziska Naepelt @ 2023-06-06 18:07 UTC (permalink / raw) To: bagasdotme Cc: davem, franziska.naepelt, franziska.naepelt, herbert, linux-crypto, linux-kernel, martin.petersen, tim.c.chen Fix the following checkpatch warning: - WARNING: Missing or malformed SPDX-License-Identifier tag Signed-off-by: Franziska Naepelt <franziska.naepelt@gmail.com> --- v2: - Remove GPL license boilerplate --- crypto/crct10dif_common.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/crypto/crct10dif_common.c b/crypto/crct10dif_common.c index b2fab366f518..28a0cdde9449 100644 --- a/crypto/crct10dif_common.c +++ b/crypto/crct10dif_common.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * Cryptographic API. * @@ -7,21 +8,6 @@ * Written by Martin K. Petersen <martin.petersen@oracle.com> * Copyright (C) 2013 Intel Corporation * Author: Tim Chen <tim.c.chen@linux.intel.com> - * - * This program is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License as published by the Free - * Software Foundation; either version 2 of the License, or (at your option) - * any later version. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, - * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF - * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND - * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS - * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN - * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN - * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE - * SOFTWARE. - * */ #include <linux/crc-t10dif.h> base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7 -- 2.39.2 (Apple Git-143) ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] crypto: crct10dif_common Add SPDX-License-Identifier tag 2023-06-06 18:07 ` [PATCH v2] " Franziska Naepelt @ 2023-06-07 3:50 ` Bagas Sanjaya 2023-06-07 5:59 ` Bagas Sanjaya 2023-06-16 12:17 ` Herbert Xu 1 sibling, 1 reply; 6+ messages in thread From: Bagas Sanjaya @ 2023-06-07 3:50 UTC (permalink / raw) To: Franziska Naepelt Cc: davem, franziska.naepelt, herbert, linux-crypto, linux-kernel, martin.petersen, tim.c.chen [-- Attachment #1: Type: text/plain, Size: 1289 bytes --] On Tue, Jun 06, 2023 at 08:07:13PM +0200, Franziska Naepelt wrote: > +// SPDX-License-Identifier: GPL-2.0-or-later > /* > * Cryptographic API. > * > @@ -7,21 +8,6 @@ > * Written by Martin K. Petersen <martin.petersen@oracle.com> > * Copyright (C) 2013 Intel Corporation > * Author: Tim Chen <tim.c.chen@linux.intel.com> > - * > - * This program is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License as published by the Free > - * Software Foundation; either version 2 of the License, or (at your option) > - * any later version. > - * > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > - * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > - * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > - * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS > - * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN > - * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > - * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > - * SOFTWARE. > - * > */ LGTM but I'll send a SPDX conversion series for crypto/ instead soon. -- An old man doll... just what I always wanted! - Clara [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] crypto: crct10dif_common Add SPDX-License-Identifier tag 2023-06-07 3:50 ` Bagas Sanjaya @ 2023-06-07 5:59 ` Bagas Sanjaya 0 siblings, 0 replies; 6+ messages in thread From: Bagas Sanjaya @ 2023-06-07 5:59 UTC (permalink / raw) To: Franziska Naepelt Cc: davem, franziska.naepelt, herbert, linux-crypto, linux-kernel, martin.petersen, tim.c.chen [-- Attachment #1: Type: text/plain, Size: 1524 bytes --] On Wed, Jun 07, 2023 at 10:50:11AM +0700, Bagas Sanjaya wrote: > On Tue, Jun 06, 2023 at 08:07:13PM +0200, Franziska Naepelt wrote: > > +// SPDX-License-Identifier: GPL-2.0-or-later > > /* > > * Cryptographic API. > > * > > @@ -7,21 +8,6 @@ > > * Written by Martin K. Petersen <martin.petersen@oracle.com> > > * Copyright (C) 2013 Intel Corporation > > * Author: Tim Chen <tim.c.chen@linux.intel.com> > > - * > > - * This program is free software; you can redistribute it and/or modify it > > - * under the terms of the GNU General Public License as published by the Free > > - * Software Foundation; either version 2 of the License, or (at your option) > > - * any later version. > > - * > > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > - * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > > - * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > > - * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS > > - * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN > > - * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > > - * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > > - * SOFTWARE. > > - * > > */ > > LGTM but I'll send a SPDX conversion series for crypto/ instead soon. > OK, here's the series [1]. [1]: https://lore.kernel.org/lkml/20230607053940.39078-10-bagasdotme@gmail.com/ -- An old man doll... just what I always wanted! - Clara [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] crypto: crct10dif_common Add SPDX-License-Identifier tag 2023-06-06 18:07 ` [PATCH v2] " Franziska Naepelt 2023-06-07 3:50 ` Bagas Sanjaya @ 2023-06-16 12:17 ` Herbert Xu 1 sibling, 0 replies; 6+ messages in thread From: Herbert Xu @ 2023-06-16 12:17 UTC (permalink / raw) To: Franziska Naepelt Cc: bagasdotme, davem, franziska.naepelt, linux-crypto, linux-kernel, martin.petersen, tim.c.chen On Tue, Jun 06, 2023 at 08:07:13PM +0200, Franziska Naepelt wrote: > Fix the following checkpatch warning: > - WARNING: Missing or malformed SPDX-License-Identifier tag > > Signed-off-by: Franziska Naepelt <franziska.naepelt@gmail.com> > --- > v2: > - Remove GPL license boilerplate > --- > crypto/crct10dif_common.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/crypto/crct10dif_common.c b/crypto/crct10dif_common.c > index b2fab366f518..28a0cdde9449 100644 > --- a/crypto/crct10dif_common.c > +++ b/crypto/crct10dif_common.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > /* > * Cryptographic API. > * > @@ -7,21 +8,6 @@ > * Written by Martin K. Petersen <martin.petersen@oracle.com> > * Copyright (C) 2013 Intel Corporation > * Author: Tim Chen <tim.c.chen@linux.intel.com> > - * > - * This program is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License as published by the Free > - * Software Foundation; either version 2 of the License, or (at your option) > - * any later version. > - * > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > - * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > - * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > - * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS > - * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN > - * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > - * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > - * SOFTWARE. > - * > */ As the text you removed does not match GPLv2 exactly I'm dropping this patch for now. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-16 12:17 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-06-06 11:03 [PATCH] crypto: crct10dif_common Add SPDX-License-Identifier tag Franziska Naepelt 2023-06-06 12:33 ` Bagas Sanjaya 2023-06-06 18:07 ` [PATCH v2] " Franziska Naepelt 2023-06-07 3:50 ` Bagas Sanjaya 2023-06-07 5:59 ` Bagas Sanjaya 2023-06-16 12:17 ` Herbert Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox