From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C705C77B73 for ; Tue, 6 Jun 2023 18:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237803AbjFFSQ1 (ORCPT ); Tue, 6 Jun 2023 14:16:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231429AbjFFSQU (ORCPT ); Tue, 6 Jun 2023 14:16:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73912170D; Tue, 6 Jun 2023 11:16:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 05D0863651; Tue, 6 Jun 2023 18:16:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A68BC433EF; Tue, 6 Jun 2023 18:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686075362; bh=inb0aKFlhB3adnPbM4bwwgiQcbLSDywTmtGkBf4rPHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CYp8Ca9Ca/V2e/bNn3Fx6RZ5GmcNa2941KImmjIOK9QBOjCaZ2kXs1JXVYuD/mB+o o8PAAF1MX2LCJdA6xTLd4WfbJjM6m2hr7EAv92ZyQTe6M6Z8aZtZBTVmguvz2kjOYN 3H+JAFgOyA7qLXnYEkvc33PXIhffIo+fCAu+5xmI4zEUoIJ8oxzzfabnEPmjIlDvGQ +roEqvxjzY1ejwFBB1+UHnRBZUyX707pAz8YuIMYdnJeuRK6RMOIVQjjsLZq5XYEKw VmXemURxWvj+9+04Pa3P+qKPY3jIf/EkvyKcDY8sBB07iiUyKSSVPgRuHHOx8iH3// WLAYlutU14hYg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 86CF340692; Tue, 6 Jun 2023 15:15:59 -0300 (-03) Date: Tue, 6 Jun 2023 15:15:59 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH V3 0/1] perf tools: Allow config terms with breakpoints Message-ID: References: <20230525082902.25332-1-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jun 06, 2023 at 08:00:33AM +0300, Adrian Hunter escreveu: > On 25/05/23 11:29, Adrian Hunter wrote: > > Hi > > > > Here is a patch (V3) to the event parser for breakpoint events. > > I am not that familiar with flex / bison, but it seemed to > > need trailing context to stop the mem event colon and slash > > delimiters from getting mixed up with delimiters for config > > terms or event modifiers. Please look closely at that. > > > > > > Changes in V3: > > > > Add Ian's Reviewed-by > > Re-base > > Still applies. Any more comments? Tried it now, twice, once after removing the O= build dir: CC /tmp/build/perf-tools-next/tests/event-times.o CC /tmp/build/perf-tools-next/tests/expr.o BISON /tmp/build/perf-tools-next/util/parse-events-bison.c util/parse-events.y:508.24-34: warning: unused value: $3 [-Wother] 508 | PE_PREFIX_MEM PE_VALUE PE_BP_SLASH PE_VALUE PE_BP_COLON PE_MODIFIER_BP opt_event_config | ^~~~~~~~~~~ util/parse-events.y:508.45-55: warning: unused value: $5 [-Wother] 508 | PE_PREFIX_MEM PE_VALUE PE_BP_SLASH PE_VALUE PE_BP_COLON PE_MODIFIER_BP opt_event_config | ^~~~~~~~~~~ util/parse-events.y:526.24-34: warning: unused value: $3 [-Wother] 526 | PE_PREFIX_MEM PE_VALUE PE_BP_SLASH PE_VALUE opt_event_config | ^~~~~~~~~~~ util/parse-events.y:543.24-34: warning: unused value: $3 [-Wother] 543 | PE_PREFIX_MEM PE_VALUE PE_BP_COLON PE_MODIFIER_BP opt_event_config | ^~~~~~~~~~~ CC /tmp/build/perf-tools-next/tests/backward-ring-buffer.o ⬢[acme@toolbox perf-tools-next]$ cat /etc/redhat-release Fedora release 36 (Thirty Six) ⬢[acme@toolbox perf-tools-next]$ rpm -q bison bison-3.8.2-2.fc36.x86_64 ⬢[acme@toolbox perf-tools-next]$ rpm -q flex flex-2.6.4-10.fc36.x86_64 ⬢[acme@toolbox perf-tools-next]$ - Arnaldo > > > > Changes in V2: > > > > Add comments to tools/perf/util/parse-events.l > > Add a test for 2 mem events back to back with config terms > > > > > > Adrian Hunter (1): > > perf tools: Allow config terms with breakpoints > > > > tools/perf/tests/parse-events.c | 157 ++++++++++++++++++++++++++++++++++++++++ > > tools/perf/util/parse-events.c | 23 +++++- > > tools/perf/util/parse-events.h | 6 +- > > tools/perf/util/parse-events.l | 23 +++++- > > tools/perf/util/parse-events.y | 42 ++++++----- > > 5 files changed, 224 insertions(+), 27 deletions(-) > > > > > > Regards > > Adrian > -- - Arnaldo