From: Christoph Hellwig <hch@infradead.org>
To: Arnaud POULIQUEN <arnaud.pouliquen@foss.st.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Jens Wiklander <jens.wiklander@linaro.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
op-tee@lists.trustedfirmware.org
Subject: Re: [RFC PATCH 1/4] tee: Re-enable vmalloc page support for shared memory
Date: Fri, 26 May 2023 05:37:56 -0700 [thread overview]
Message-ID: <ZHCoJEkVinvsB2lZ@infradead.org> (raw)
In-Reply-To: <18a8528d-7d9d-6ed0-0045-5ee47dd39fb2@foss.st.com>
On Wed, May 24, 2023 at 04:01:14PM +0200, Arnaud POULIQUEN wrote:
> > As per the discussion back then: don't just blindly do the same dumb
> > thing again and fix the interfae to actually pass in a page array,
> > or iov_iter or an actually useful container that fits.
> >
>
> I suppose your are speaking about this discussion:
> https://lore.kernel.org/all/20221002002326.946620-3-ira.weiny@intel.com/
Yes.
>
> If I'm not mistaken, I should modify at tee_shm_register_kernel_buf API and
> register_shm_helper inernal function, right?
>
> What about having equivalent of shm_get_kernel_pages in an external helper (to
> defined where to put it), could it be an alternative of the upadate of the
> tee_shm API?
I think the fundamentally right thing is to pass an iov_iter to
register_shm_helper, and then use the new as of 6.3
iov_iter_extract_pages helper to extract the pages from that. For
the kernel users you can then simply pass down an ITER_BVEC iter
that you can fill with vmalloc pages if you want.
next prev parent reply other threads:[~2023-05-26 12:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 9:13 [RFC PATCH 0/4] introduction of a remoteproc tee to load signed firmware images Arnaud Pouliquen
2023-05-23 9:13 ` [RFC PATCH 1/4] tee: Re-enable vmalloc page support for shared memory Arnaud Pouliquen
2023-05-24 6:46 ` Christoph Hellwig
2023-05-24 14:01 ` Arnaud POULIQUEN
2023-05-26 12:37 ` Christoph Hellwig [this message]
2023-05-29 7:17 ` Arnaud POULIQUEN
2023-05-23 9:13 ` [RFC PATCH 2/4] remoteproc: Add TEE support Arnaud Pouliquen
2023-05-24 6:50 ` Christoph Hellwig
2023-05-23 9:13 ` [RFC PATCH 3/4] dt-bindings: remoteproc: add compatibility for " Arnaud Pouliquen
2023-05-30 11:50 ` Krzysztof Kozlowski
2023-05-30 15:00 ` Arnaud POULIQUEN
2023-05-30 15:12 ` Krzysztof Kozlowski
2023-05-23 9:13 ` [RFC PATCH 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware Arnaud Pouliquen
2023-05-30 16:20 ` [RFC PATCH 0/4] introduction of a remoteproc tee to load signed firmware images Mathieu Poirier
2023-05-30 17:12 ` Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHCoJEkVinvsB2lZ@infradead.org \
--to=hch@infradead.org \
--cc=andersson@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox