From: Tyler Hicks <code@tyhicks.com>
To: Hardik Garg <hargar@linux.microsoft.com>
Cc: stable@vger.kernel.org, shuah@kernel.org, jeffxu@google.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
niyelchu@linux.microsoft.com
Subject: Re: [PATCH 6.1 5.15 5.10 5.4 4.19 4.14] selftests/memfd: Fix unknown type name build failure
Date: Fri, 26 May 2023 20:21:59 -0500 [thread overview]
Message-ID: <ZHFbN7lVu7gdwCcE@sequoia> (raw)
In-Reply-To: <20230526232136.255244-1-hargar@linux.microsoft.com>
On 2023-05-26 16:21:36, Hardik Garg wrote:
> Partially backport v6.3 commit 11f75a01448f ("selftests/memfd: add
> tests for MFD_NOEXEC_SEAL MFD_EXEC") to fix an unknown type name
> build error.
> In some systems, the __u64 typedef is not present due to differences
> in system headers, causing compilation errors like this one:
>
> fuse_test.c:64:8: error: unknown type name '__u64'
> 64 | static __u64 mfd_assert_get_seals(int fd)
>
> This header includes the __u64 typedef which increases the
> likelihood of successful compilation on a wider variety of systems.
>
> Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>
Reviewed-by: Tyler Hicks (Microsoft) <code@tyhicks.com>
Tyler
> ---
> tools/testing/selftests/memfd/fuse_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/memfd/fuse_test.c b/tools/testing/selftests/memfd/fuse_test.c
> index be675002f918..93798c8c5d54 100644
> --- a/tools/testing/selftests/memfd/fuse_test.c
> +++ b/tools/testing/selftests/memfd/fuse_test.c
> @@ -22,6 +22,7 @@
> #include <linux/falloc.h>
> #include <fcntl.h>
> #include <linux/memfd.h>
> +#include <linux/types.h>
> #include <sched.h>
> #include <stdio.h>
> #include <stdlib.h>
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-05-27 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 23:21 [PATCH 6.1 5.15 5.10 5.4 4.19 4.14] selftests/memfd: Fix unknown type name build failure Hardik Garg
2023-05-27 1:21 ` Tyler Hicks [this message]
2023-05-28 7:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHFbN7lVu7gdwCcE@sequoia \
--to=code@tyhicks.com \
--cc=hargar@linux.microsoft.com \
--cc=jeffxu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=niyelchu@linux.microsoft.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox