From: andy.shevchenko@gmail.com
To: Astrid Rost <astrid.rost@axis.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@axis.com,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Mathieu Othacehe" <m.othacehe@gmail.com>
Subject: Re: [PATCH v4 3/7] iio: light: vcnl4000: Add als_it for vcnl4040/4200
Date: Mon, 29 May 2023 01:42:39 +0300 [thread overview]
Message-ID: <ZHPY32XPGyc96jJS@surfacebook> (raw)
In-Reply-To: <20230522142621.1680563-4-astrid.rost@axis.com>
Mon, May 22, 2023 at 04:26:17PM +0200, Astrid Rost kirjoitti:
> Add illuminance integration time for vcnl4040 and vcnl4200.
> Add read/write attribute for illuminance integration time and read
> attribute for available integration times.
> Set scale and sampling rate according to the integration time.
...
> + data->vcnl4200_al.sampling_rate = ktime_set(0, val * 1200000);
> + if (data->id == VCNL4200)
> + /* 24000 µlux/step * 50000 µs / val */
> + data->al_scale = div_u64(1200000000, val);
Without type these constant are integers. Is this okay with 32-bit builds?
> + else
> + /* 100000 µlux/step * 80000 µs / val */
> + data->al_scale = div_u64(8000000000, val);
Ditto.
Also, can you use constants from units.h (KILO) and time.h (USEC_PER_MSEC)?
...
> +out:
out_unlock:
> + mutex_unlock(&data->vcnl4000_lock);
> + return ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-05-28 22:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 14:26 [PATCH v4 0/7] iio: light: vcnl4000: Add features for vncl4040/4200 Astrid Rost
2023-05-22 14:26 ` [PATCH v4 1/7] iio: light: vcnl4000: Add proximity irq for vcnl4200 Astrid Rost
2023-05-22 14:26 ` [PATCH v4 2/7] iio: light: vcnl4000: Add proximity ps_it " Astrid Rost
2023-05-22 14:26 ` [PATCH v4 3/7] iio: light: vcnl4000: Add als_it for vcnl4040/4200 Astrid Rost
2023-05-28 22:42 ` andy.shevchenko [this message]
2023-05-29 9:25 ` Astrid Rost
2023-05-22 14:26 ` [PATCH v4 4/7] iio: light: vcnl4000: add illuminance irq vcnl4040/4200 Astrid Rost
2023-05-28 22:45 ` andy.shevchenko
2023-05-29 7:41 ` Astrid Rost
2023-05-29 9:02 ` Andy Shevchenko
2023-06-04 13:10 ` Jonathan Cameron
2023-05-22 14:26 ` [PATCH v4 5/7] iio: light: vcnl4000: Add period for vcnl4040/4200 Astrid Rost
2023-05-29 5:20 ` andy.shevchenko
2023-05-22 14:26 ` [PATCH v4 6/7] iio: light: vcnl4000: Add oversampling_ratio for 4040/4200 Astrid Rost
2023-05-28 19:03 ` Jonathan Cameron
2023-05-29 5:22 ` andy.shevchenko
2023-05-22 14:26 ` [PATCH v4 7/7] iio: light: vcnl4000: Add calibration bias " Astrid Rost
2023-05-29 5:26 ` andy.shevchenko
2023-05-28 19:01 ` [PATCH v4 0/7] iio: light: vcnl4000: Add features for vncl4040/4200 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHPY32XPGyc96jJS@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=astrid.rost@axis.com \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.othacehe@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox