public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ladislav Michl <oss-lists@triops.cz>
To: Franziska Naepelt <franziska.naepelt@googlemail.com>
Cc: linux-mips@vger.kernel.org, tsbogend@alpha.franken.de,
	linux-kernel@vger.kernel.org,
	Franziska Naepelt <franziska.naepelt@gmail.com>
Subject: Re: [PATCH] mips: Fix spacing issue
Date: Mon, 29 May 2023 15:51:32 +0200	[thread overview]
Message-ID: <ZHSt5JKOc1hwEGTv@lenoch> (raw)
In-Reply-To: <20230529113421.8970-1-franziska.naepelt@gmail.com>

Hi,

coould we just fix all whitespaces while there?

diff --git a/arch/mips/sibyte/swarm/platform.c b/arch/mips/sibyte/swarm/platform.c
index 484969db7713..339d77a0a08f 100644
--- a/arch/mips/sibyte/swarm/platform.c
+++ b/arch/mips/sibyte/swarm/platform.c
@@ -88,15 +88,15 @@ device_initcall(swarm_pata_init);
 #define sb1250_dev_struct(num) \
 	static struct resource sb1250_res##num = {		\
 		.name = "SB1250 MAC " __stringify(num),		\
-		.flags = IORESOURCE_MEM,		\
-		.start = A_MAC_CHANNEL_BASE(num),	\
-		.end = A_MAC_CHANNEL_BASE(num + 1) -1,	\
+		.flags = IORESOURCE_MEM,			\
+		.start = A_MAC_CHANNEL_BASE(num),		\
+		.end = A_MAC_CHANNEL_BASE(num + 1) - 1,		\
 	};\
 	static struct platform_device sb1250_dev##num = {	\
-		.name = "sb1250-mac",			\
-	.id = num,					\
-	.resource = &sb1250_res##num,			\
-	.num_resources = 1,				\
+		.name = "sb1250-mac",				\
+		.id = num,					\
+		.resource = &sb1250_res##num,			\
+		.num_resources = 1,				\
 	}
 
 sb1250_dev_struct(0);

On Mon, May 29, 2023 at 01:34:21PM +0200, Franziska Naepelt wrote:
> This removes the following checkpatch issue:
> - ERROR: need consistent spacing around '-' (ctx:WxV)
> 
> Signed-off-by: Franziska Naepelt <franziska.naepelt@gmail.com>
> ---
>  arch/mips/sibyte/swarm/platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/sibyte/swarm/platform.c b/arch/mips/sibyte/swarm/platform.c
> index 484969db7713..06bf7105e7b1 100644
> --- a/arch/mips/sibyte/swarm/platform.c
> +++ b/arch/mips/sibyte/swarm/platform.c
> @@ -90,7 +90,7 @@ device_initcall(swarm_pata_init);
>  		.name = "SB1250 MAC " __stringify(num),		\
>  		.flags = IORESOURCE_MEM,		\
>  		.start = A_MAC_CHANNEL_BASE(num),	\
> -		.end = A_MAC_CHANNEL_BASE(num + 1) -1,	\
> +		.end = A_MAC_CHANNEL_BASE(num + 1) - 1,	\
>  	};\
>  	static struct platform_device sb1250_dev##num = {	\
>  		.name = "sb1250-mac",			\
> 
> base-commit: 7877cb91f1081754a1487c144d85dc0d2e2e7fc4
> -- 
> 2.39.2 (Apple Git-143)

  reply	other threads:[~2023-05-29 13:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-29 11:34 [PATCH] mips: Fix spacing issue Franziska Naepelt
2023-05-29 13:51 ` Ladislav Michl [this message]
2023-05-30  7:19   ` Franziska Näpelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZHSt5JKOc1hwEGTv@lenoch \
    --to=oss-lists@triops.cz \
    --cc=franziska.naepelt@gmail.com \
    --cc=franziska.naepelt@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox