From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E378C77B7E for ; Mon, 29 May 2023 21:54:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbjE2VyD (ORCPT ); Mon, 29 May 2023 17:54:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjE2VyC (ORCPT ); Mon, 29 May 2023 17:54:02 -0400 Received: from smtp.dudau.co.uk (dliviu.plus.com [80.229.23.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AA179C1; Mon, 29 May 2023 14:53:59 -0700 (PDT) Received: from mail.dudau.co.uk (bart.dudau.co.uk [192.168.14.2]) by smtp.dudau.co.uk (Postfix) with SMTP id F023641D13A6; Mon, 29 May 2023 22:53:57 +0100 (BST) Received: by mail.dudau.co.uk (sSMTP sendmail emulation); Mon, 29 May 2023 22:53:57 +0100 Date: Mon, 29 May 2023 22:53:57 +0100 From: Liviu Dudau To: Conor Dooley Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Thomas Bogendoerfer , Paul Burton , Rob Herring , Sergio Paracuellos , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: mips: Add bindings for TP-Link HC220 G5 v1 board Message-ID: References: <84b31c59-81d3-c83d-ece9-a120b1cdcdd7@arinc9.com> <20230529150833.526084-1-liviu@dudau.co.uk> <20230529150833.526084-3-liviu@dudau.co.uk> <20230529-unhook-alone-1b1bd6e6a226@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230529-unhook-alone-1b1bd6e6a226@spud> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 29, 2023 at 10:00:20PM +0100, Conor Dooley wrote: > Hey, Hi Conor, > > On Mon, May 29, 2023 at 04:08:33PM +0100, Liviu Dudau wrote: > > Add bindings for the compatible string used for the TP-Link's > > HC220 G5 V1 board, a wireless AP based on MT7621. > > > > Signed-off-by: Liviu Dudau > > Two process things: > - Please run get_maintainer.pl against the current git tree - you seem > to have missed 2 of the 3 dt-bindings maintainers. I don't mind my > omission, but omitting Krzysztof means you're submitting patches based > on a tree that is over a year old. Appologies for that, I should have check get_maintainer.pl rather than looking at the output of git log for the file. > - Please don't send a v2 in reply to the v1. Sorry, I'm not sure why that makes any difference. Reason for sending it as a reply was the fact that last conversation was more than two weeks ago, people might have forgot the context. This way it's all in one thread. > > > --- > > Documentation/devicetree/bindings/mips/ralink.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mips/ralink.yaml b/Documentation/devicetree/bindings/mips/ralink.yaml > > index 704b5b5951271..53c1f66353770 100644 > > --- a/Documentation/devicetree/bindings/mips/ralink.yaml > > +++ b/Documentation/devicetree/bindings/mips/ralink.yaml > > @@ -80,6 +80,7 @@ properties: > > - enum: > > - gnubee,gb-pc1 > > - gnubee,gb-pc2 > > + - tplink,hc220-g5-v1 > > For the actual change though, > Acked-by: Conor Dooley Many thanks! Best regards, Liviu > > Thanks, > Conor. > > > - const: mediatek,mt7621-soc > > > > additionalProperties: true > > -- > > 2.40.1 > > -- Everyone who uses computers frequently has had, from time to time, a mad desire to attack the precocious abacus with an axe. -- John D. Clark, Ignition!