From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: gregkh@linuxfoundation.org, r-gunasekaran@ti.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tps6598x: Fix broken polling mode after system suspend/resume
Date: Tue, 30 May 2023 11:26:39 +0300 [thread overview]
Message-ID: <ZHWzP6qsgzSayhIO@kuha.fi.intel.com> (raw)
In-Reply-To: <20230530065926.6161-1-rogerq@kernel.org>
On Tue, May 30, 2023 at 09:59:26AM +0300, Roger Quadros wrote:
> During system resume we need to resume the polling workqueue
> if client->irq is not set else polling will no longer work.
>
> Fixes: 0d6a119cecd7 ("usb: typec: tps6598x: Add support for polling interrupts status")
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tipd/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 438cc40660a1..603dbd44deba 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -920,7 +920,7 @@ static int __maybe_unused tps6598x_resume(struct device *dev)
> enable_irq(client->irq);
> }
>
> - if (client->irq)
> + if (!client->irq)
> queue_delayed_work(system_power_efficient_wq, &tps->wq_poll,
> msecs_to_jiffies(POLL_INTERVAL));
>
> --
> 2.34.1
--
heikki
prev parent reply other threads:[~2023-05-30 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 6:59 [PATCH] usb: typec: tps6598x: Fix broken polling mode after system suspend/resume Roger Quadros
2023-05-30 8:26 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHWzP6qsgzSayhIO@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox