Re: [PATCH v5 RESEND 10/17] s390: mm: Convert to GENERIC_IOREMAP

Christoph Hellwig
2023-05-17T08:08:28Z

On Wed, May 17, 2023 at 09:58:26AM +0200, Niklas Schnelle wrote:
> > and just define this to ioremap_wc. Note that defining _wt to _wc is
> > very odd and seems wrong, but comes from the existing code. Maybe the
> > s390 maintainers can chime on on the background and we can add a comment
> > while we're at it.
>
> I'm a bit confused where you see ioremap_wt() defined to ioremap_wc()
> in the existing code? Our current definitions are:

No, it's me wo is confused. They clearly are different. But the same
comment about just moving ioremap_wc applies to ioremap_wt based
on how pgprot_writethrough is implemented then.