Re: [PATCH v5 RESEND 11/17] sh: mm: Convert to GENERIC_IOREMAP

Christoph Hellwig
2023-05-17T06:38:00Z

On Mon, May 15, 2023 at 05:08:42PM +0800, Baoquan He wrote:
> Meanwhile, add macro definitions for port|mm io functions since SuperH
> has its own implementation in arch/sh/kernel/iomap.c and
> arch/sh/include/asm/io_noioport.h. These will conflict with the port|mm io
> function definitions in include/asm-generic/io.h to cause compiling
> errors like below:

Please split that inclusion of include/asm-generic/io.h and redefining
of the helpers into a separate prep patch.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>