From: Johan Hovold <johan@kernel.org>
To: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Matthias Kaehlcke <mka@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH 0/2] Bluetooth: fix bdaddr quirks
Date: Tue, 30 May 2023 16:25:09 +0200 [thread overview]
Message-ID: <ZHYHRW-9BN4n4pPs@hovoldconsulting.com> (raw)
In-Reply-To: <20230424133542.14383-1-johan+linaro@kernel.org>
On Mon, Apr 24, 2023 at 03:35:40PM +0200, Johan Hovold wrote:
> These patches fixes a couple of issues with the two bdaddr quirks:
>
> The first one allows HCI_QUIRK_INVALID_BDADDR to be used with
> HCI_QUIRK_NON_PERSISTENT_SETUP.
>
> The second patch restores the original semantics of the
> HCI_QUIRK_USE_BDADDR_PROPERTY so that the controller is marked as
> unconfigured when no device address is specified in the devicetree (as
> the quirk is documented to work).
>
> This specifically makes sure that Qualcomm HCI controllers such as
> wcn6855 found on the Lenovo X13s are marked as unconfigured until user
> space has provided a valid address.
>
> Long term, the HCI_QUIRK_USE_BDADDR_PROPERTY should probably be dropped
> in favour of HCI_QUIRK_INVALID_BDADDR and always checking the devicetree
> property.
> Johan Hovold (2):
> Bluetooth: fix invalid-bdaddr quirk for non-persistent setup
> Bluetooth: fix use-bdaddr-property quirk
>
> net/bluetooth/hci_sync.c | 30 +++++++++++-------------------
> 1 file changed, 11 insertions(+), 19 deletions(-)
Any further comments to this series, or can this one be merged for 6.5
now?
Johan
next prev parent reply other threads:[~2023-05-30 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 13:35 [PATCH 0/2] Bluetooth: fix bdaddr quirks Johan Hovold
2023-04-24 13:35 ` [PATCH 1/2] Bluetooth: fix invalid-bdaddr quirk for non-persistent setup Johan Hovold
2023-05-02 23:44 ` Luiz Augusto von Dentz
2023-05-03 7:55 ` Johan Hovold
2023-04-24 13:35 ` [PATCH 2/2] Bluetooth: fix use-bdaddr-property quirk Johan Hovold
2023-05-30 14:25 ` Johan Hovold [this message]
2023-05-30 20:06 ` [PATCH 0/2] Bluetooth: fix bdaddr quirks Luiz Augusto von Dentz
2023-05-31 9:11 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHYHRW-9BN4n4pPs@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johan+linaro@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox