From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFC7C77B7A for ; Wed, 31 May 2023 15:03:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233844AbjEaPDt (ORCPT ); Wed, 31 May 2023 11:03:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232598AbjEaPDp (ORCPT ); Wed, 31 May 2023 11:03:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19E3B138 for ; Wed, 31 May 2023 08:03:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 91265614EF for ; Wed, 31 May 2023 15:03:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA719C433D2; Wed, 31 May 2023 15:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685545410; bh=1NyD5pfHsfbl2eDOdqvK6NDW3YPW7b+qYBFMf162c10=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QYOPA593iZ7cdIeo4ig0xhhoCxpVSRGSpY/eKabfzbbevQ/ffWUGbW5vp2ILTKV6A 2kS5mIsfINA1tZShCk6pL2cQiDKW0rmq4oCAo+QxN/UODvpU+0tUbut3Nzq24l6PV7 1jepZsuQh9ABIq9VDxKfzAh8gFLqtGbPdneXNpIL7nSWSssbfCW5MaMl7Al/4Fte2X nG93WA9+UxNw8VWHCfjFqq1JZ7tTotbdLPoeHlWdLDcKOUmMo5gsbZquIwodlmOUZ5 InXqLasASiTWrT+/9oPMbpXeE2kgHoacn626XthkeOmIZnLfwcQjQLQZhuuzNr0Tzd ZYd4b46NxrY1g== Date: Wed, 31 May 2023 22:52:14 +0800 From: Jisheng Zhang To: Catalin Marinas Cc: Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] riscv: allow kmalloc() caches aligned to the smallest value Message-ID: References: <20230526165958.908-1-jszhang@kernel.org> <20230526165958.908-6-jszhang@kernel.org> <20230529-fidelity-booted-0d4055d1f559@wendy> <20230530-gyration-handheld-ef4e44e89d61@wendy> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2023 at 02:08:10PM +0100, Catalin Marinas wrote: > On Tue, May 30, 2023 at 11:34:06AM +0100, Conor Dooley wrote: > > On Tue, May 30, 2023 at 10:59:41AM +0100, Catalin Marinas wrote: > > > On Mon, May 29, 2023 at 12:17:46PM +0100, Conor Dooley wrote: > > > > On Sat, May 27, 2023 at 12:59:57AM +0800, Jisheng Zhang wrote: > > > > > After this patch, a simple test of booting to a small buildroot rootfs > > > > > on qemu shows: > > > > > > > > > > kmalloc-96 5041 5041 96 ... > > > > > kmalloc-64 9606 9606 64 ... > > > > > kmalloc-32 5128 5128 32 ... > > > > > kmalloc-16 7682 7682 16 ... > > > > > kmalloc-8 10246 10246 8 ... > > > > > > > > > > So we save about 1268KB memory. The saving will be much larger in normal > > > > > OS env on real HW platforms. > > > > > > > > > > [1] Link: https://lore.kernel.org/linux-arm-kernel/20230524171904.3967031-1-catalin.marinas@arm.com/ > > > > While I think of it, Link: goes at the start of the line, the [1] should > > go at the end (although I don't think you actually reference the link > > anywhere in the text & it'll probably not be particularly relevant if a > > subsequent revision of that patchset is applied. > > I plan to post at least one more. I'd suggest the risc-v patchset to > only go in once my series landed. Sure I will wait for your series landing in linus tree firstly. > > > > > > Signed-off-by: Jisheng Zhang > > > > > > > > Fails to build chief, with loads of: > > > > linux/dma-mapping.h:546:19: error: redefinition of 'dma_get_cache_alignment' > > > > > > > > And for 32-bit there's also a rake of: > > > > include/linux/slab.h:239:9: warning: 'ARCH_KMALLOC_MINALIGN' macro redefined [-Wmacro-redefined] > > > > > > > > At the very least, reproducable with rv32_defconfig. > > > > > > Have you this it on top of the KMALLOC_MINALIGN preparation series? > > > > > > https://lore.kernel.org/r/20230524171904.3967031-1-catalin.marinas@arm.com/ > > > > Oh, no. Thanks for pointing that out. > > Our automation stuff only uses what is in riscv/{for-next,master,fixes}. > > Unless my reading comprehension is particularly bad of late it was Aha I dunno this mechanism before. > > non-obvious that this depended on something that had not yet been Your reading comprehension is good ;) I just listed the dependency but didn't explictly mention its merge status. I will wait for Catalin's series being merged.