* [PATCH] bpf: cleanup unused function declaration
@ 2023-06-02 3:08 GONG, Ruiqi
2023-06-02 16:12 ` Stanislav Fomichev
0 siblings, 1 reply; 3+ messages in thread
From: GONG, Ruiqi @ 2023-06-02 3:08 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann
Cc: John Fastabend, Andrii Nakryiko, Martin KaFai Lau, bpf,
linux-kernel, Wang Weiyang, Xiu Jianfeng, gongruiqi1
All usage and the definition of `bpf_prog_free_linfo()` has been removed
in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and
jited_linfo"). Clean up its declaration in the header file.
Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>
---
include/linux/filter.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/filter.h b/include/linux/filter.h
index bbce89937fde..f69114083ec7 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp);
bool bpf_opcode_in_insntable(u8 code);
-void bpf_prog_free_linfo(struct bpf_prog *prog);
void bpf_prog_fill_jited_linfo(struct bpf_prog *prog,
const u32 *insn_to_jit_off);
int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf: cleanup unused function declaration
2023-06-02 3:08 [PATCH] bpf: cleanup unused function declaration GONG, Ruiqi
@ 2023-06-02 16:12 ` Stanislav Fomichev
2023-06-05 23:32 ` Andrii Nakryiko
0 siblings, 1 reply; 3+ messages in thread
From: Stanislav Fomichev @ 2023-06-02 16:12 UTC (permalink / raw)
To: gongruiqi
Cc: Alexei Starovoitov, Daniel Borkmann, John Fastabend,
Andrii Nakryiko, Martin KaFai Lau, bpf, linux-kernel,
Wang Weiyang, Xiu Jianfeng, gongruiqi1
On 06/02, GONG, Ruiqi wrote:
> All usage and the definition of `bpf_prog_free_linfo()` has been removed
> in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and
> jited_linfo"). Clean up its declaration in the header file.
>
> Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
> ---
> include/linux/filter.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/filter.h b/include/linux/filter.h
> index bbce89937fde..f69114083ec7 100644
> --- a/include/linux/filter.h
> +++ b/include/linux/filter.h
> @@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp);
>
> bool bpf_opcode_in_insntable(u8 code);
>
> -void bpf_prog_free_linfo(struct bpf_prog *prog);
> void bpf_prog_fill_jited_linfo(struct bpf_prog *prog,
> const u32 *insn_to_jit_off);
> int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf: cleanup unused function declaration
2023-06-02 16:12 ` Stanislav Fomichev
@ 2023-06-05 23:32 ` Andrii Nakryiko
0 siblings, 0 replies; 3+ messages in thread
From: Andrii Nakryiko @ 2023-06-05 23:32 UTC (permalink / raw)
To: Stanislav Fomichev
Cc: gongruiqi, Alexei Starovoitov, Daniel Borkmann, John Fastabend,
Andrii Nakryiko, Martin KaFai Lau, bpf, linux-kernel,
Wang Weiyang, Xiu Jianfeng, gongruiqi1
On Fri, Jun 2, 2023 at 9:12 AM Stanislav Fomichev <sdf@google.com> wrote:
>
> On 06/02, GONG, Ruiqi wrote:
> > All usage and the definition of `bpf_prog_free_linfo()` has been removed
> > in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and
> > jited_linfo"). Clean up its declaration in the header file.
> >
> > Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>
>
I'm actually having trouble applying this locally. Can you please
rebase against bpf-next/master and resend it? Also, please check
Signed-off-by's "<first> <last> <email>" order and spelling. Should it
be "Ruiqi Gong <...>"?
> Acked-by: Stanislav Fomichev <sdf@google.com>
>
> > ---
> > include/linux/filter.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/filter.h b/include/linux/filter.h
> > index bbce89937fde..f69114083ec7 100644
> > --- a/include/linux/filter.h
> > +++ b/include/linux/filter.h
> > @@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp);
> >
> > bool bpf_opcode_in_insntable(u8 code);
> >
> > -void bpf_prog_free_linfo(struct bpf_prog *prog);
> > void bpf_prog_fill_jited_linfo(struct bpf_prog *prog,
> > const u32 *insn_to_jit_off);
> > int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-05 23:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-02 3:08 [PATCH] bpf: cleanup unused function declaration GONG, Ruiqi
2023-06-02 16:12 ` Stanislav Fomichev
2023-06-05 23:32 ` Andrii Nakryiko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox